Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"flutter test" command should not require libGL dependency #8306

Closed
yyoon opened this issue Feb 21, 2017 · 3 comments
Closed

"flutter test" command should not require libGL dependency #8306

yyoon opened this issue Feb 21, 2017 · 3 comments
Assignees
Labels
customer: fuchsia engine flutter/engine repository. See also e: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@yyoon
Copy link
Contributor

yyoon commented Feb 21, 2017

flutter test command uses sky_shell to execute the tests in non-interactive mode.
However, because sky_shell also supports interactive mode, it requires the libGL libraries such as libGL.so.1.

This is causing us issues with running flutter tests on LUCI build bots, because the builder machines does not have libGL libraries installed.

Ideally, flutter test should use a version of sky_shell without the libGL dependency.

cc/ @chinmaygarde

@eseidelGoogle eseidelGoogle added engine flutter/engine repository. See also e: labels. team: infra customer: fuchsia labels Feb 21, 2017
@eseidelGoogle
Copy link
Contributor

@chinmaygarde is on this now. :) Thanks!

@Hixie Hixie added this to the No milestone necessary milestone Feb 28, 2017
@chinmaygarde
Copy link
Member

Update: We have removed the dependency on GL, FontConfig and a few other libraries from the test shell. However, Skia seems to be linking it in all the same. I will need to patch that and do a roll.

@Hixie Hixie added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed team: infra labels Apr 23, 2018
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer: fuchsia engine flutter/engine repository. See also e: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

No branches or pull requests

4 participants