Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing engine releases for Flutter channels #84821

Open
jwinarske opened this issue Jun 18, 2021 · 7 comments
Open

Testing engine releases for Flutter channels #84821

jwinarske opened this issue Jun 18, 2021 · 7 comments
Labels
d: api docs Issues with https://api.flutter.dev/ engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jwinarske
Copy link

jwinarske commented Jun 18, 2021

What is the official way to test for a channel roll?

Is this it?

https://github.com/flutter/flutter/blob/beta/bin/internal/engine.version
https://github.com/flutter/flutter/blob/stable/bin/internal/engine.version

I wouldn't expect the two channels to have the same value

Also what about roll backs?

@TahaTesser TahaTesser added the in triage Presently being triaged by the triage team label Jun 18, 2021
@TahaTesser
Copy link
Member

Hi @jwinarske
The reason why currently stable and beta have the same value because they're on the same version right now

As you can see, the same framework, engine, and release timestamp (beta is likely to receive another update soon)
stable

[✓] Flutter (Channel stable, 2.2.2, on Microsoft Windows [Version 10.0.19043.1055], locale en-US)
    • Flutter version 2.2.2 at C:\Users\Taha\Code\flutter_stable
    • Framework revision d79295af24 (7 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

beta

[✓] Flutter (Channel beta, 2.2.2, on Microsoft Windows [Version 10.0.19043.1055], locale en-US)
    • Flutter version 2.2.2 at C:\Users\Taha\Code\flutter_beta
    • Framework revision d79295af24 (7 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

What is the official way to test for a channel roll?

Can you please clarify what you testing with this? engine?
Thank you

@TahaTesser TahaTesser added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jun 18, 2021
@jwinarske
Copy link
Author

Sorry I should have explained better. I have a CI job that checks for channel roll every 15 minutes using the mentioned endpoints, for the purpose of re-spinning engine build. Just wondering if using the mentioned endpoints is the best / most direct way?

Also for desktop debug builds I use this endpoint:
https://storage.googleapis.com/flutter_infra/flutter/91c9fc8fe011352879e3bb6660966eafc0847233/linux-x64/linux-x64-embedder

A couple of channel rolls ago there was no artifact for a couple of days, and for the latest roll there is no build artifact at all.

Is the linux-x64-embedder build artifact deprecated (removed from pipeline builds)?

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jun 18, 2021
@TahaTesser TahaTesser changed the title Testing for channel roll? Testing for channel roll Jun 21, 2021
@TahaTesser TahaTesser added documentation team-infra Owned by Infrastructure team engine flutter/engine repository. See also e: labels. and removed in triage Presently being triaged by the triage team labels Jun 21, 2021
@stuartmorgan stuartmorgan removed the team-infra Owned by Infrastructure team label Jun 21, 2021
@stuartmorgan
Copy link
Contributor

What is a "channel roll"? AFAIK there's no Flutter process with that name, so it's not really clear what the question is here without a definition of what exactly it is that you want to do.

@TahaTesser
Copy link
Member

TahaTesser commented Jun 21, 2021

The author wants to test check the version for the engine, every 15 minutes using the following links

https://github.com/flutter/flutter/blob/beta/bin/internal/engine.version
https://github.com/flutter/flutter/blob/stable/bin/internal/engine.version

They want to know if this is the best way to do the check for the engine version

@jwinarske
Correct me If I'm mistaken

@TahaTesser TahaTesser added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jun 21, 2021
@jwinarske
Copy link
Author

@TahaTesser you are correct.

The follow up to that is the build artifact missing, and is that part of a deprecation plan?

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jun 21, 2021
@TahaTesser
Copy link
Member

@jwinarske
I am not sure about the missing artifact, somebody from infra could answer it better

@TahaTesser TahaTesser changed the title Testing for channel roll Testing engine releases for Flutter channels Jun 21, 2021
@stuartmorgan
Copy link
Contributor

What is the official way to test for a channel roll?

There's no "official" way to be informed of an engine rolling having been released to a specific channel, but

Is this it?

https://github.com/flutter/flutter/blob/beta/bin/internal/engine.version
https://github.com/flutter/flutter/blob/stable/bin/internal/engine.version

Those files are (currently; there's no guarantee that the format of internal wouldn't change in the future) the source of truth for what version of the engine is being used in a given version of Flutter.

Also what about roll backs?

There is no difference from the perspective of the flutter tool between a roll and a rollback. The value in that file changes, and a new version is used.

Is the linux-x64-embedder build artifact deprecated (removed from pipeline builds)?

No, but going forward artifacts are uploaded to flutter_infra_release, not flutter_infra. I'll update the custom embedder wiki page.

@chinmaygarde chinmaygarde added the P2 Important issues not at the top of the work list label Jun 21, 2021
@flutter-triage-bot flutter-triage-bot bot added the d: api docs Issues with https://api.flutter.dev/ label Jul 5, 2023
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: api docs Issues with https://api.flutter.dev/ engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

5 participants