reconcile and rename fuchsia variables used in GN build rules #85088
Labels
a: build
Building flutter applications with the tool
dependency: fuchsia
Fuchsia team may need to help us
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
flutter/buildroot
build/fuchsia/sdk.gni
has adeclare_args
section that defines a set of "global" variables reused by many other.gni
andBUILD.gn
files, such asfuchsia_sdk_root
.Some of these variables are ambiguous (
fuchsia_sdk_root
vs.fuchsia_sdk_path
, for instance), and some variable names may misrepresent the state of the build environment.For example,
using_fuchsia_gn_sdk = false
. As part of flutter/engine#26880, I'm currently updatingDEPS
to import the Fuchsia GN SDK (instead of the Fuchsia SDK), but it doesn't appear to be possible (or at least, practical) to setusing_fuchsia_gn_sdk = true
. I suspect that the variable's value may not actually correspond to whether flutter is building with the Fuchsia GN SDK, or with the Fuchsia SDK, so if the variable still has value, it would help to update the variable name, and expand on the associated comment insdk.gni
to better reflect its purpose.Perhaps this should be done as part of #67373 (if it's easier to make all of these changes at once), or separately if not.
The text was updated successfully, but these errors were encountered: