Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile and rename fuchsia variables used in GN build rules #85088

Open
richkadel opened this issue Jun 23, 2021 · 0 comments
Open

reconcile and rename fuchsia variables used in GN build rules #85088

richkadel opened this issue Jun 23, 2021 · 0 comments
Labels
a: build Building flutter applications with the tool dependency: fuchsia Fuchsia team may need to help us engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@richkadel
Copy link
Contributor

flutter/buildroot build/fuchsia/sdk.gni has a declare_args section that defines a set of "global" variables reused by many other .gni and BUILD.gn files, such as fuchsia_sdk_root.

Some of these variables are ambiguous (fuchsia_sdk_root vs. fuchsia_sdk_path, for instance), and some variable names may misrepresent the state of the build environment.

For example, using_fuchsia_gn_sdk = false. As part of flutter/engine#26880, I'm currently updating DEPS to import the Fuchsia GN SDK (instead of the Fuchsia SDK), but it doesn't appear to be possible (or at least, practical) to set using_fuchsia_gn_sdk = true. I suspect that the variable's value may not actually correspond to whether flutter is building with the Fuchsia GN SDK, or with the Fuchsia SDK, so if the variable still has value, it would help to update the variable name, and expand on the associated comment in sdk.gni to better reflect its purpose.

Perhaps this should be done as part of #67373 (if it's easier to make all of these changes at once), or separately if not.

@richkadel richkadel added the team-infra Owned by Infrastructure team label Jun 23, 2021
@godofredoc godofredoc added a: build Building flutter applications with the tool engine flutter/engine repository. See also e: labels. passed secondary triage and removed team-infra Owned by Infrastructure team labels Aug 5, 2021
@chinmaygarde chinmaygarde added P2 Important issues not at the top of the work list dependency: fuchsia Fuchsia team may need to help us labels Aug 9, 2021
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: build Building flutter applications with the tool dependency: fuchsia Fuchsia team may need to help us engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

4 participants