-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web][regression] text autofill doesn't work #86497
Comments
Hi @arualana Used the following minimal code sample minimal code sampleimport 'package:flutter/material.dart';
import 'package:flutter/services.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Material App',
theme: ThemeData.dark(),
home: Home(),
);
}
}
class Home extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text('Material App Bar'),
),
body: Center(
child: ListView(
children: <Widget>[
AutofillGroup(
child: Column(
children: <Widget>[
TextFormField(
autofillHints: const <String>[
AutofillHints.username,
AutofillHints.email
],
),
TextFormField(
autofillHints: const <String>[AutofillHints.password],
),
ElevatedButton(
child: Text('Sign In'),
onPressed: () {
TextInput.finishAutofillContext();
},
)
],
),
),
],
),
),
floatingActionButton: FloatingActionButton(
child: Icon(Icons.add),
onPressed: () {},
),
);
}
}
Steps to reproduce
Results:
|
chrome |
canvaskit | html |
---|---|---|
debug | ❌ | ❌ |
stable |
beta |
dev |
master |
---|---|---|---|
✅ | ❌ | ❌ | ❌ |
Check flutter doctor -v
outputs for each channel below
flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 12.0 21A5284e darwin-x64, locale en-GB)
• Flutter version 2.2.3 at /Users/tahatesser/Code/flutter_stable
• Framework revision f4abaa0735 (2 weeks ago), 2021-07-01 12:46:11 -0700
• Engine revision 241c87ad80
• Dart version 2.13.4
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/tahatesser/Code/SDK
• Platform android-30, build-tools 30.0.3
• ANDROID_HOME = /Users/tahatesser/Code/SDK
• Java binary at: /Users/tahatesser/Code/openjdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.5.1, Build version 12E507
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[✓] VS Code (version 1.58.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.24.0
[✓] Connected device (3 available)
• iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios •
com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
• macOS (desktop) • macos • darwin-x64 • macOS
12.0 21A5284e darwin-x64
• Chrome (web) • chrome • web-javascript • Google
Chrome 91.0.4472.164
! Doctor found issues in 1 category.
[✓] Flutter (Channel beta, 2.3.0-24.1.pre, on macOS 12.0 21A5284e darwin-x64,
locale en-GB)
• Flutter version 2.3.0-24.1.pre at /Users/tahatesser/Code/flutter_beta
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 615957513e (3 weeks ago), 2021-06-25 09:24:44 -0700
• Engine revision 9d517f475b
• Dart version 2.14.0 (build 2.14.0-188.5.beta)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/tahatesser/Code/SDK
• Platform android-30, build-tools 30.0.3
• ANDROID_HOME = /Users/tahatesser/Code/SDK
• Java binary at: /Users/tahatesser/Code/openjdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build
1.8.0_292-b10)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.5.1, Build version 12E507
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[✓] VS Code (version 1.58.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.24.0
[✓] Connected device (3 available)
• iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios
• com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
• macOS (desktop) • macos • darwin-x64
• macOS 12.0 21A5284e darwin-x64
• Chrome (web) • chrome •
web-javascript • Google Chrome 91.0.4472.164
! Doctor found issues in 1 category.
[✓] Flutter (Channel dev, 2.4.0-4.0.pre, on macOS 12.0 21A5284e darwin-x64,
locale en-GB)
• Flutter version 2.4.0-4.0.pre at /Users/tahatesser/Code/flutter_dev
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision cc00e7e6bc (5 days ago), 2021-07-11 18:21:02 -0400
• Engine revision ed25e8f01e
• Dart version 2.14.0 (build 2.14.0-301.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/tahatesser/Code/SDK
• Platform android-30, build-tools 30.0.3
• ANDROID_HOME = /Users/tahatesser/Code/SDK
• Java binary at: /Users/tahatesser/Code/openjdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build
1.8.0_292-b10)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.5.1, Build version 12E507
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[✓] VS Code (version 1.58.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.24.0
[✓] Connected device (3 available)
• iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios
• com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
• macOS (desktop) • macos • darwin-x64
• macOS 12.0 21A5284e darwin-x64
• Chrome (web) • chrome •
web-javascript • Google Chrome 91.0.4472.164
! Doctor found issues in 1 category.
[✓] Flutter (Channel master, 2.4.0-5.0.pre.76, on macOS 12.0 21A5284e
darwin-x64, locale en-GB)
• Flutter version 2.4.0-5.0.pre.76 at /Users/tahatesser/Code/flutter_master
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 8cf1de3e68 (8 hours ago), 2021-07-16 01:11:02 -0400
• Engine revision c2ffafea35
• Dart version 2.14.0 (build 2.14.0-321.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/tahatesser/Code/SDK
• Platform android-30, build-tools 30.0.3
• ANDROID_HOME = /Users/tahatesser/Code/SDK
• Java binary at: /Users/tahatesser/Code/openjdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (AdoptOpenJDK)(build
1.8.0_292-b10)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.5.1, Build version 12E507
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[!] Android Studio
• Android Studio at /Applications/Android Studio Preview.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
✗ Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[✓] VS Code (version 1.58.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.24.0
[✓] Connected device (3 available)
• iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios
• com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
• macOS (desktop) • macos • darwin-x64
• macOS 12.0 21A5284e darwin-x64
• Chrome (web) • chrome •
web-javascript • Google Chrome 91.0.4472.164
! Doctor found issues in 1 category.
✅ : No Issue ❌: Issue reproduced
2.3.0-16.0.pre
2.3.0-16.0.pre
Hi @TahaTesser is there any update on this? has it been moved to low priority? |
Same issue |
i swith to stable. but not work too C:\Users\bulic\AndroidStudioProjects\crmdb>flutter --version |
Same issue. This functionality ceased working roughly about when we upgraded to Flutter 2.5.0. No error messages. flutter --versionFlutter 2.5.1 • channel stable • https://github.com/flutter/flutter.git |
I think its because of added shadowRoute node in Dom. |
Is any information? |
Doesn't anyone use autofill that developers can ignore this error so long? |
flutter web "autofill" function is not performed in version higher than 2.3.0-0.1.pre. |
Same issue here that creates issues with our applications. Are there any updates/progress? |
Having the same issue on Flutter 2.5.0, |
#94043 seems to fix it on Firefox, but not on Chrome. Haven't tested in Safari or any other browser |
Oops, that's what I meant to link, my bad! #95210 does indeed fix it on Android and Firefox from my tests, but does not change anything on Chrome (again, haven't tested Safari or anything else). |
Does anyone have any further updates on this issue? Even with latest autofill fixes now in master they don't fix the autofill of two fields, user/email and password, in Chrome.
I had the same results testing #95210. Chrome does suggest autofill for email/username but it does not autofill from the password manager like it use to (I tested in 2.2.3 stable). |
Hi, already flutter upgraded on 2.8.1 version, but autofill stil not worked in web. does no one use this? |
I also have same issue on chrome. |
This still happens on the latest stable 2.10.2 |
Still on flutter.2.10.4. Are only 12 people concerned about this? |
Surprised this has zero progress yet. Did anyone come with some workarounds, except implementing own autofill with local storage? |
I can reproduce the fact autofill starts working when you bring the inputs out of the Shadow DOM, but there's a catch. After launching Chrome Canary with the |
This is still an issue on Flutter 3.3.4. At least finally iOS and Android autofill seems to work (not sure what version fixed it, but it was broken for a while). Here is a hosted sample so you can see it not working: https://rexios80.github.io/flutter_autofill_test/stable And the repo that built that: https://github.com/Rexios80/flutter_autofill_test |
If that sample app doesn't work then no |
I updated that repo to auto deploy builds for flutter channel stable, beta, and master every week so I don't have to maintain it anymore. https://rexios80.github.io/flutter_autofill_test/stable |
Oh ok, thanks for the feedback. |
I believe this can be deduplicated with #87735. Please feel free to reopen if I'm wrong. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
We have a login form with just email and password
This used to work I think until 2.3.0-0.1.pre, and broke at 2.3.0-16.0.pre
I am not 100% sure which one was the upgrade that stopped it from working (I am sure it was one upgrade, though), but it was recently, and further upgrades have not solved the problem
The data is actually stored (i.e. I get the prompt to ask if I want to save/update the data in the browser and I can see it in settings -> autofill -> passwords) but there is no autofill happening on the password, the username/email only gets auto-filled
The code simplified
The text was updated successfully, but these errors were encountered: