Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NavigationBar widget with Material 3 support #88888

Closed
Tracked by #91605
rami-a opened this issue Aug 25, 2021 · 5 comments · Fixed by #83047
Closed
Tracked by #91605

Introduce NavigationBar widget with Material 3 support #88888

rami-a opened this issue Aug 25, 2021 · 5 comments · Fixed by #83047
Assignees
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@rami-a
Copy link
Member

rami-a commented Aug 25, 2021

Use case

Allow developers that are using Material You/v3 to have a correctly styled NavigationBar

Proposal

Introduce a new widget called NavigationBar that can be used as a replacement for BottomNavigationBar. The previous component has some outdated tech debt and features from earlier versions of the Material spec.

@rami-a rami-a self-assigned this Aug 25, 2021
@rami-a rami-a added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 25, 2021
@bernaferrari
Copy link
Contributor

Can you use NavigationBar at the top? Because there were some things in the initial implementation that prevented this.

@rami-a
Copy link
Member Author

rami-a commented Aug 25, 2021

Conceptually, it is meant to be used at the bottom.

Technically, I don't think there would be any reason why you couldn't use it at the top (though the preferred use is to provide it to the bottomNavigationBar field of scaffold.

@bernaferrari
Copy link
Contributor

If I remember well, the tooltip only works/worked on bottom (otherwise it wouldn't be shown).

@rami-a
Copy link
Member Author

rami-a commented Aug 26, 2021

If I remember well, the tooltip only works/worked on bottom (otherwise it wouldn't be shown).

Ah, then I believe that issue persists in this new version (for now) but I think adding a way to theme (allow customizing the position/style/etc) the tooltip would be straightforward and non-breaking to land in a follow-up PR

@TahaTesser TahaTesser added passed first triage c: proposal A detailed proposal for a change to Flutter labels Aug 31, 2021
@rami-a rami-a changed the title [Material You] Introduce NavigationBar widget with Material You styling [Material v3] Introduce NavigationBar widget with Material You styling Sep 1, 2021
@rami-a rami-a changed the title [Material v3] Introduce NavigationBar widget with Material You styling [Material 3] Introduce NavigationBar widget with Material You styling Sep 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
@guidezpl guidezpl changed the title [Material 3] Introduce NavigationBar widget with Material You styling Introduce NavigationBar widget with Material You styling Mar 30, 2022
@guidezpl guidezpl changed the title Introduce NavigationBar widget with Material You styling Introduce NavigationBar widget with Material 3 support Mar 30, 2022
@guidezpl guidezpl changed the title Introduce NavigationBar widget with Material 3 support Introduce NavigationBar widget with Material 3 support May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants