Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining leaks in the linux shell #90155

Open
bdero opened this issue Sep 15, 2021 · 0 comments
Open

Fix remaining leaks in the linux shell #90155

bdero opened this issue Sep 15, 2021 · 0 comments
Labels
engine flutter/engine repository. See also e: labels. from: sanitizer Issues caught by engine sanitizers. May be false positives. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@bdero
Copy link
Member

bdero commented Sep 15, 2021

Remove the sanitizer suppressions in lsan_suppressions.txt in the linux shell and fix the remaining leaks:

leak:*flutter/shell/platform/linux/fl_keyboard_manager_test.cc*
leak:*flutter/shell/platform/linux/fl_key_channel_responder_test.cc*
leak:*flutter/shell/platform/linux/fl_basic_message_channel_test.cc*
leak:fl_message_codec_decode_message
@bdero bdero added engine flutter/engine repository. See also e: labels. from: sanitizer Issues caught by engine sanitizers. May be false positives. P2 Important issues not at the top of the work list labels Sep 15, 2021
@bdero bdero mentioned this issue Sep 15, 2021
Merged
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. from: sanitizer Issues caught by engine sanitizers. May be false positives. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hixie @bdero @TahaTesser