Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow or async event around raster cache populate->eviction events #92286

Closed
Tracked by #91855
flar opened this issue Oct 21, 2021 · 2 comments · Fixed by flutter/engine#29298
Closed
Tracked by #91855

Add flow or async event around raster cache populate->eviction events #92286

flar opened this issue Oct 21, 2021 · 2 comments · Fixed by flutter/engine#29298
Labels
engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@flar
Copy link
Contributor

flar commented Oct 21, 2021

We don't provide any statistics on how long cache entries remain in use. It would be nice if the creation and deletion of an individual cache entry added events to the timeline then we could visualize and potentially graph that time frame.

@chinmaygarde chinmaygarde changed the title Add flow or asynch event around raster cache populate->eviction events Add flow or async event around raster cache populate->eviction events Oct 21, 2021
@chinmaygarde
Copy link
Member

After staring at traces with @goderbauer, I think we preferred flow events because we could select a whole bunch of them and analyze/graph their durations. This would give us a good idea about how long each entry sticks around in the cache.

@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. passed first triage team Infra upgrades, team productivity, code health, technical debt. See also team: labels. and removed in triage Presently being triaged by the triage team labels Oct 22, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P2 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. P0 Critical issues such as a build break or regression team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants