Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter iOS app should set CADisableMinimumFrameDurationOnPhone to true in info.plist by default #94508

Closed
cyanglaz opened this issue Dec 1, 2021 · 3 comments · Fixed by #94509
Closed

Flutter iOS app should set CADisableMinimumFrameDurationOnPhone to true in info.plist by default #94508

cyanglaz opened this issue Dec 1, 2021 · 3 comments · Fixed by #94509
Assignees
@cyanglaz
Labels
P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@cyanglaz
Copy link
Contributor

cyanglaz commented Dec 1, 2021 •
edited

CADisableMinimumFrameDurationOnPhone is required for an iOS app not to be restricted to 60hz frame rate on iPhone 13 pro and beyond.
To support high frame rate for newer devices, we should enable this by default in the template.
For existing app, a migration is needed.

Note that enabling this is not sufficient for a flutter app to reach higher frame rate. Some other work is required for that to happen.
See:
@cyanglaz cyanglaz self-assigned this Dec 1, 2021
@cyanglaz cyanglaz added P2 Important issues not at the top of the work list P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. and removed P2 Important issues not at the top of the work list labels Dec 1, 2021
@cyanglaz cyanglaz mentioned this issue Dec 1, 2021
Merged
8 tasks
@Hixie
Copy link
Contributor

Hixie commented Dec 3, 2021

here's a proposed api for the framework: master...Hixie:freq

@jmagman
Copy link
Member

jmagman commented Mar 9, 2022

Example for migrating this in existing apps: https://gist.github.com/jmagman/d7b76fc20ff5d5808f6ce26ea3d622e9

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cyanglaz cyanglaz

Labels
P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates cyanglaz/flutter
4 participants
@Hixie @jmagman @cyanglaz @darshankawar