Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker][iOS]: With Select Photos access, selecting a different GIF than the one selected earlier won't animate. #96263

Closed
m-j-g opened this issue Jan 7, 2022 · 3 comments · Fixed by flutter/plugins#7084
Closed

[image_picker][iOS]: With Select Photos access, selecting a different GIF than the one selected earlier won't animate. #96263

m-j-g opened this issue Jan 7, 2022 · 3 comments · Fixed by flutter/plugins#7084
Assignees
@vashworth
Labels
found in release: 2.8 Found to occur in 2.8 found in release: 2.9 Found to occur in 2.9 has reproducible steps The issue has been confirmed reproducible and is ready to work on p: image_picker The Image Picker plugin. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically r: fixed Issue is closed as already fixed in a newer version

Comments

@m-j-g
Copy link

m-j-g commented Jan 7, 2022 •
edited
Loading

This issue was closed without being resolved: #77281

If you choose "Select Photos" permission and select a gif, THAT gif will work. However, next time you click to pick a photo, if you select a different gif it won't be animated. Only the ones selected in the "Select Photos" permission step will be animated.

So, what keeps happening is people leave reviews saying that the app doesn't support gifs. They click the picker, click the "Select Photos" permission, select a photo. Then every time they use the app after that they are using different gifs from the picker and they don't work.

Video from the latest image_picker example:

RPReplay_picker.mov
@darshankawar darshankawar added the in triage Presently being triaged by the triage team label Jan 7, 2022
@darshankawar
Copy link
Member

This issue was closed without being resolved

@m-j-g The issue was indeed resolved, but was for a different scenario. The scenario you reported here is a bit different from the one that was fixed.
I verified this using latest stable and master version and using latest plugin version and observed the same behavior, as described below:

  1. With Select Photos access, after selecting a GIF, it again brings up the screen and on this screen, if we select another GIF (which is different from the one we selected at first place), then the newly selected GIF doesn't play:
RPReplay-Final1641542472.mov
  1. Using the same scenario but with Allow All Access, both GIFs plays properly (because of the fact that an additional screen isn't shown for this access:
RPReplay-Final1641542880.MP4

Code sample used: https://pub.dev/packages/image_picker/example

stable, master flutter doctor -v 
[[✓] Flutter (Channel stable, 2.8.1, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.8.1 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (13 hours ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/dhs/Library/Android/sdk
    • Java binary at: /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.    

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)        

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 93.0.4577.82


• No issues found!

[✓] Flutter (Channel master, 2.9.0-1.0.pre.266, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.9.0-1.0.pre.266 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dd4db8738a (2 hours ago), 2022-01-06 18:36:24 -0800
    • Engine revision 849877954b
    • Dart version 2.16.0 (build 2.16.0-144.0.dev)
    • DevTools version 2.9.2
    • PATH =
      /usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/binpplicat
      ions/Software_Setup/flutter/bin:/Users/dhs/triagemagic/bin/:/Users/dhs/doc
      uments/fluttersdk/flutter/bin:/emulator:/tools:/tools/bin:/platform-tools:
      /Users/dhs/.pub-cache/bin
    
[✓] Android toolchain - develop for Android devices (Android SDK version 30)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/dhs/Library/Android/sdk
    • Java binary at: /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.    

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/dhs/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)        

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 93.0.4577.82


• No issues found!

@darshankawar
Copy link
Member

/cc @mvanbeusekom

@darshankawar darshankawar added p: first party p: image_picker The Image Picker plugin. platform-ios iOS applications specifically found in release: 2.8 Found to occur in 2.8 found in release: 2.9 Found to occur in 2.9 has reproducible steps The issue has been confirmed reproducible and is ready to work on and removed in triage Presently being triaged by the triage team labels Jan 7, 2022
@darshankawar darshankawar changed the title [image_picker] GIF doesn't work on iOS 14 when user chooses "Select Photos" access [image_picker][iOS]: With Select Photos access, selecting a different GIF than the one selected earlier won't animate. Jan 7, 2022
@stuartmorgan stuartmorgan added P2 Important issues not at the top of the work list passed secondary triage labels Jan 13, 2022
@vashworth vashworth mentioned this issue Jan 31, 2023
Open
@vashworth vashworth self-assigned this Feb 1, 2023
@vashworth vashworth mentioned this issue Feb 2, 2023
Merged
11 tasks
@darshankawar darshankawar added the r: fixed Issue is closed as already fixed in a newer version label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vashworth vashworth

Labels
found in release: 2.8 Found to occur in 2.8 found in release: 2.9 Found to occur in 2.9 has reproducible steps The issue has been confirmed reproducible and is ready to work on p: image_picker The Image Picker plugin. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
4 participants
@stuartmorgan @m-j-g @vashworth @darshankawar