-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing integration tests for Flutter on Android #97853
Comments
Here is the tracking issue #83731 to run framework tests on engine. |
This issue is marked P1 but has had no recent status updates. The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub. Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks! |
cc @mariamhas for prioritization |
P2 is the right priority for now |
There are a few scenarios that don't have integration tests.
Due to the lack of tests, customers get bugs that are fatal in many cases. e.g. application crash.
We just had one of these issues recently.
Some scenarios:
Shell::OnPlatformViewDestroyed
followed byShell::OnPlatformViewCreated
.This can happen when the app is sent to the background or the app switch is toggled, then the app is brought to the foreground.
detectLeakedClosableObjects()
, maybe others too.systemNavigationBarDividerColor
changesstatusBarIconBrightness
andsystemNavigationBarIconBrightness
on Android11 #100027To begin, these scenarios should leverage Android emulators, so they can run on presubmit checks. They should also run as part of the engine presubmit checks.
cc @GaryQian
cc @godofredoc @keyonghan I believe there was a plan to run some frameworks tests in the engine. Could we run these in the engine once added?
The text was updated successfully, but these errors were encountered: