Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing integration tests for Flutter on Android #97853

Open
9 tasks
blasten opened this issue Feb 5, 2022 · 4 comments
Open
9 tasks

Missing integration tests for Flutter on Android #97853

blasten opened this issue Feb 5, 2022 · 4 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@blasten
Copy link

blasten commented Feb 5, 2022

There are a few scenarios that don't have integration tests.
Due to the lack of tests, customers get bugs that are fatal in many cases. e.g. application crash.

We just had one of these issues recently.

Some scenarios:

To begin, these scenarios should leverage Android emulators, so they can run on presubmit checks. They should also run as part of the engine presubmit checks.

cc @GaryQian

cc @godofredoc @keyonghan I believe there was a plan to run some frameworks tests in the engine. Could we run these in the engine once added?

@blasten blasten added a: tests "flutter test", flutter_test, or one of our tests platform-android Android applications specifically engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list labels Feb 5, 2022
@keyonghan
Copy link
Contributor

Here is the tracking issue #83731 to run framework tests on engine.

@flutter-triage-bot
Copy link

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

@camsim99 camsim99 added P2 Important issues not at the top of the work list triaged-android Triaged by Android platform team and removed P1 High-priority issues at the top of the work list labels Aug 17, 2023
@camsim99
Copy link
Contributor

cc @mariamhas for prioritization

@mariamhas
Copy link

P2 is the right priority for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Development

No branches or pull requests

7 participants