Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ButtonStyleButton docs #98692

Closed
Piinks opened this issue Feb 17, 2022 · 1 comment · Fixed by #99088
Closed

Fix ButtonStyleButton docs #98692

Piinks opened this issue Feb 17, 2022 · 1 comment · Fixed by #99088
Assignees
@Piinks
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list

Comments

@Piinks
Copy link
Contributor

Piinks commented Feb 17, 2022

From @rydmike in #98537 (comment)

In ButtonStyleButton there is also a doc ref to MaterialButton that I suspect should be to ButtonStyleButton instead, or just as a normal text "Material button" as a reference to the Material button concept itself, rather than a doc ref to a class that has nothing to do with ButtonStyleButton where the reference is.

flutter/packages/flutter/lib/src/material/button_style_button.dart

Line 425 in 8a6d0d6

/// A widget to pad the area around a [MaterialButton]'s inner [Material].

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ documentation labels Feb 17, 2022
@Piinks Piinks self-assigned this Feb 17, 2022
@Piinks Piinks mentioned this issue Feb 17, 2022
Open
@Piinks Piinks added the P2 Important issues not at the top of the work list label Feb 17, 2022
This was referenced Feb 23, 2022
Closed
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Piinks Piinks

Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
1 participant
@Piinks