Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New buttons should use InkSparkle for splashFactory when useMaterial3 is true #99884

Closed
Tracked by #91605
clocksmith opened this issue Mar 10, 2022 · 1 comment · Fixed by #100794
Closed
Tracked by #91605

New buttons should use InkSparkle for splashFactory when useMaterial3 is true #99884

clocksmith opened this issue Mar 10, 2022 · 1 comment · Fixed by #100794
Assignees
@darrenaustin @clocksmith
Labels
c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@clocksmith
Copy link
Contributor

Currently, the new buttons provide their own splashFactory and do not inherit the ThemeData.splashFactory.

One solution is for the buttons need to manually adjust the splashFactory the same way ThemeData does.

Another solution would be to make sure that the new Buttons properly inherit splashFactory from ThemeData.
@clocksmith clocksmith added the f: material design flutter/packages/flutter/material repository. label Mar 10, 2022
This was referenced Mar 10, 2022
Merged
Closed
@clocksmith clocksmith changed the title [Material] New buttons should use InkSparkle when useMaterial3 is true [Material] New buttons should use InkSparkle for splashFactory when useMaterial3 is true Mar 10, 2022
@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. c: new feature Nothing broken; request for a new capability labels Mar 10, 2022
@darrenaustin darrenaustin mentioned this issue Mar 25, 2022
Merged
8 tasks
@guidezpl guidezpl mentioned this issue Apr 26, 2022
Closed
70 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
@guidezpl guidezpl changed the title [Material] New buttons should use InkSparkle for splashFactory when useMaterial3 is true New buttons should use InkSparkle for splashFactory when useMaterial3 is true May 23, 2022
@guidezpl guidezpl changed the title New buttons should use InkSparkle for splashFactory when useMaterial3 is true New buttons should use InkSparkle for splashFactory when useMaterial3 is true May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darrenaustin darrenaustin

@clocksmith clocksmith

Labels
c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
Material 3
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate common buttons to Material 3 darrenaustin/flutter
3 participants
@darrenaustin @clocksmith @darshankawar