Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dialog.fullscreen and example #112261

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Add Dialog.fullscreen and example #112261

merged 1 commit into from
Sep 29, 2022

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Sep 23, 2022 •
edited

fixes #104961

This PR adds Dialog. fullscreen, which allows the creation of a fullscreen dialog.

Screen.Recording.2022-09-27.at.16.10.53.mov

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Sep 23, 2022
@TahaTesser
Copy link
Member Author

@guidezpl
Created Dialog.fullscreen based on our discussion #104961 (comment)

werainkhatri
werainkhatri approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blue flutter

examples/api/lib/material/dialog/dialog.0.dart Outdated Show resolved Hide resolved
examples/api/test/material/dialog/dialog.0_test.dart Outdated Show resolved Hide resolved
@TahaTesser
Add Dialog.fullscreen and example
6c7cbf7 
Update example

Update parameters

Update template
@HansMuller HansMuller merged commit fd6997f into flutter:master Sep 29, 2022
@TahaTesser TahaTesser deleted the m3_full_screen_dialog branch September 29, 2022 18:30
This was referenced Sep 30, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
fd6997f07 Add Dialog.fullscreen and example (flutter/flutter#112261)
8f39ea1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
fd6997f Add Dialog.fullscreen and example (flutter/flutter#112261)
2f38e44
@art926 art926 mentioned this pull request Dec 15, 2022
Closed
@OlegBezr
Copy link

@TahaTesser thank you for the great work! Do you know if this feature made it into any flutter releases? It seems that there's no Dialog.fullscreen in the last stable release - 3.3.10, but it's also not in the latest beta version - 3.7.0-1.2.pre. Do you know when this feature is planned to be released? Is there a way to track it?

@TahaTesser
Copy link
Member Author

Hi @OlegBezr
It should be available on the beta channel. You can track the commit here and version tags associated with the commit.

Screenshot 2022-12-20 at 15 35 44

I can also see the source code in beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for full screen dialogs
5 participants
@TahaTesser @OlegBezr @guidezpl @werainkhatri @HansMuller