Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Re-enable web benchmarks #463

Closed
guidezpl opened this issue Mar 25, 2021 · 5 comments · Fixed by #604
Closed

Re-enable web benchmarks #463

guidezpl opened this issue Mar 25, 2021 · 5 comments · Fixed by #604
Assignees
Labels
bug Something isn't working P1 Priority 1 - Must have

Comments

@guidezpl
Copy link
Member

guidezpl commented Mar 25, 2021

It seems Chrome 89 brought a change that causes the benchmarks to fail. To enable development, they've been disabled.

@guidezpl
Copy link
Member Author

guidezpl commented Dec 9, 2021

Hey @pennzht could you take a look? Benchmarks aren't currently running

@amanv8060
Copy link
Contributor

Hi @guidezpl , I have made pr here to add the changes introduced, but this pr requires knowledge of setting up the tests from basics, which I don't know . I would be more than happy to read something to get started on writing tests.

@guidezpl
Copy link
Member Author

Oh nice, thanks. I don't have any more specific knowledge for testing than the guides on the Dart and Flutter docs sites. I'm not aware of browser testing that is version specific, do you have more info @yjbanov?

@yjbanov
Copy link
Contributor

yjbanov commented Feb 17, 2022

@ditman and @amanv8060 just fixed package:web_benchmarks. @ditman will attempt to reenable the gallery benchmark now.

@ditman ditman mentioned this issue Feb 17, 2022
8 tasks
@ditman
Copy link
Member

ditman commented Feb 17, 2022

Here's the PR reenabling the web benchmarks: #604

I hope it helps. Thanks to @amanv8060 for the initial fix to web_benchmarks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P1 Priority 1 - Must have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants