Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Drop Flare Dependency #375

Merged
merged 105 commits into from Nov 16, 2020
Merged

Drop Flare Dependency #375

merged 105 commits into from Nov 16, 2020

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented Nov 16, 2020 •
edited

This PR:

  1. Reconstructs the settings icon on the home page.
  2. Drops the dependency on Flare from the Gallery.
  3. Updates goldens.

We remove the dependency on Flare in order to migrate Gallery to NNBD, as there is currently no plan to migrate Flare to NNBD.

@pennzht
On this branch, I will rewrite the icon for the menu button on the ba…
71bfb91 
…ckdrop.
@pennzht
Merge branch 'master' into x-icon
c5ab107
@pennzht
Add some experiments.
8067f80
@pennzht
Add more experiment.
4ab37d6
@pennzht
Add icon/colors.txt.
f9b74d4
@pennzht
Add metrics.
0348cd7
@pennzht
Move directory.
d997a98
@pennzht
Modify.
e0bacce
@pennzht
Add times for animation.
b8ec95c
@pennzht
Add flare_icon.dart.
0e15e1a
@pennzht
Setting up framework.
d173dbd
@pennzht
Add SIP.
b1cff4e
@pennzht
Add more changes.
e8163e7
@pennzht
Remove unused LayoutBuilder.
f03ff6a
@pennzht
Remove AspectRatio.
5f82b57
@pennzht
Add scaling.
ad118db
@pennzht
Add _size.
e650aca
@pennzht
Rename to unitHeight and unitWidth.
fc073f3
@pennzht
Add icon.dart.
8bab6d7
@pennzht
Add more metrics.
c00605f
@pennzht
Add more metrics.x
ef2a0f1
@pennzht
Add more metrics.
bf2b658
@pennzht
Add initial experiment.
ded1779
@pennzht
Add more metrics.
90e17bd
@pennzht
Add experiment.
fd48b01
@pennzht
Add paintStick.
24cc7df
@pennzht
Experiment with the x-icon.
dadc2c2
@pennzht
Almost!
4166700
@pennzht
First success!
ddd1cc0
@pennzht
Remove unused flare imports.
85c1c92
perclasson
perclasson approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome 🎉

guidezpl
guidezpl approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@pennzht pennzht merged commit 92b31c4 into flutter:master Nov 16, 2020
@pennzht pennzht mentioned this pull request Nov 16, 2020
Closed
@rami-a rami-a mentioned this pull request Nov 16, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perclasson perclasson perclasson approved these changes

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pennzht @perclasson @guidezpl