Skip to content

Commit

Permalink
[camera] Fix Android lint issues (#3993)
Browse files Browse the repository at this point in the history
Fixes the new lints that came with a recent AGP update, and removes the baseline file.

Fixes flutter/flutter#126710
Part of flutter/flutter#88011
  • Loading branch information
stuartmorgan committed May 16, 2023
1 parent 66fdea5 commit b971830
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 34 deletions.
3 changes: 2 additions & 1 deletion packages/camera/camera_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 0.10.8+1

* Fixes lint errors.
* Updates minimum supported SDK version to Flutter 3.3/Dart 2.18.

## 0.10.8
Expand Down
5 changes: 0 additions & 5 deletions packages/camera/camera_android/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ android {
compileSdkVersion 33

defaultConfig {
targetSdkVersion 31
minSdkVersion 21
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
Expand All @@ -48,10 +47,6 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}

lint {
baseline = file("lint-baseline.xml")
}

testOptions {
unitTests.includeAndroidResources = true
unitTests.returnDefaultValues = true
Expand Down
26 changes: 0 additions & 26 deletions packages/camera/camera_android/android/lint-baseline.xml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ interface CameraDeviceWrapper {
@TargetApi(Build.VERSION_CODES.P)
void createCaptureSession(SessionConfiguration config) throws CameraAccessException;

@TargetApi(Build.VERSION_CODES.LOLLIPOP)
void createCaptureSession(
@NonNull List<Surface> outputs,
@NonNull CameraCaptureSession.StateCallback callback,
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Android implementation of the camera plugin.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22

version: 0.10.8
version: 0.10.8+1

environment:
sdk: ">=2.18.0 <4.0.0"
Expand Down

0 comments on commit b971830

Please sign in to comment.