Skip to content

Commit

Permalink
Update xcode to 14c18 (#3774)
Browse files Browse the repository at this point in the history
With https://flutter-review.googlesource.com/c/recipes/+/42160, we are ready to make all tests consistent with xcode 14c18.
  • Loading branch information
keyonghan committed Apr 28, 2023
1 parent 3dc59f9 commit c71747d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,24 @@ platform_properties:
properties:
dependencies: >-
[
{"dependency": "xcode", "version": "14a5294e"},
{"dependency": "xcode", "version": "14c18"},
{"dependency": "gems", "version": "v3.3.14"}
]
os: Mac-12
device_type: none
cpu: arm64
xcode: 14a5294e # xcode 14.0 beta 5
xcode: 14c18
mac_x64:
properties:
dependencies: >-
[
{"dependency": "xcode", "version": "14a5294e"},
{"dependency": "xcode", "version": "14c18"},
{"dependency": "gems", "version": "v3.3.14"}
]
os: Mac-12
device_type: none
cpu: x86
xcode: 14a5294e # xcode 14.0 beta 5
xcode: 14c18

targets:
### iOS+macOS tasks ***
Expand Down
4 changes: 2 additions & 2 deletions .ci/scripts/create_simulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

# The name here must match remove_simulator.sh
readonly DEVICE_NAME=Flutter-iPhone
readonly DEVICE=com.apple.CoreSimulator.SimDeviceType.iPhone-13
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-0
readonly DEVICE=com.apple.CoreSimulator.SimDeviceType.iPhone-14
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-16-2

xcrun simctl list
xcrun simctl create "$DEVICE_NAME" "$DEVICE" "$OS" | xargs xcrun simctl boot
2 changes: 1 addition & 1 deletion .ci/targets/ios_platform_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ tasks:
args: ["xcode-analyze", "--ios", "--ios-min-version=13.0"]
- name: native test
script: script/tool_runner.sh
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=iPhone 13,OS=latest"]
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=iPhone 14,OS=latest"]
- name: drive examples
# `drive-examples` contains integration tests, which changes the UI of the application.
# This UI change sometimes affects `xctest`.
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/tool/shared/test_suites.dart
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ Future<int> _runIOSPluginUnitTests(String testPluginPath) async {
return runXcodeBuild(
'$examplePath/ios',
sdk: 'iphonesimulator',
destination: 'platform=iOS Simulator,name=iPhone 13',
destination: 'platform=iOS Simulator,name=iPhone 14',
extraArguments: <String>['test'],
);
}
Expand Down

0 comments on commit c71747d

Please sign in to comment.