Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rfw] fix macos debug entitlements for wasm example #2958

Merged
merged 2 commits into from
Feb 1, 2023
Merged

[rfw] fix macos debug entitlements for wasm example #2958

merged 2 commits into from
Feb 1, 2023

Conversation

dkbast
Copy link
Contributor

@dkbast dkbast commented Dec 16, 2022

The macos version of the rfw wasm example was missing debug entitlements to connect to the internet and fetch the remote file.

This is related to flutter/flutter#90218

I belive no changes to CHANGELOG.md or pubspec.yaml are necessary as this does not affect the pub release.

Tagging @Hixie for review.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkbast dkbast requested a review from Hixie as a code owner December 16, 2022 20:39
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Dec 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Dec 16, 2022
@Hixie
Copy link
Contributor

Hixie commented Dec 16, 2022

test-exempt: testing this would require running the example on a mac host and doing network traffic, which would be unfortunately rather flake-prone.

@Hixie Hixie added the override: no versioning needed Override the check requiring version bumps for most changes label Dec 16, 2022
@Hixie
Copy link
Contributor

Hixie commented Dec 16, 2022

Might be worth adding a CHANGELOG entry just for people to know we changed something.

Hixie
Hixie reviewed Dec 16, 2022
View reviewed changes
packages/rfw/example/wasm/macos/Runner/DebugProfile.entitlements
@@ -8,5 +8,7 @@
<true/>
<key>com.apple.security.network.server</key>
<true/>
<key>com.apple.security.network.client</key>
<true/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this to the other entitlements too? (notably the release mode one)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely be in the release entitlements as well.

Hixie
Hixie approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(This will need a second reviewer before it can land.)

@Hixie Hixie mentioned this pull request Dec 23, 2022
Open
stuartmorgan
stuartmorgan requested changes Jan 10, 2023
View reviewed changes
packages/rfw/example/wasm/macos/Runner/DebugProfile.entitlements
@@ -8,5 +8,7 @@
<true/>
<key>com.apple.security.network.server</key>
<true/>
<key>com.apple.security.network.client</key>
<true/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely be in the release entitlements as well.

@stuartmorgan
Copy link
Contributor

@dkbast Are you planning on updating this based on my comment above?

@dkbast
Copy link
Contributor Author

dkbast commented Feb 1, 2023

Added it to the release entitlements as well.

The example itself is still not running under M1 mac, as reported here: flutter/flutter#90218

stuartmorgan
stuartmorgan approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Feb 1, 2023
@stuartmorgan
Copy link
Contributor

Override: running the example is a dev-only change, so exempt from changelog and version changes.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2023
@auto-submit auto-submit bot merged commit f14b713 into flutter:main Feb 1, 2023
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@dkbast @Maatteogekko
[rfw] fix macos debug entitlements for wasm example (flutter#2958)
59ec7ef 
* [rfw] fix macos debug entitlements

* [rfw] fix macos release entitlements

---------

Co-authored-by: Damian Bast <me@damianbast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: rfw Remote Flutter Widgets
Projects
None yet
Milestone
No milestone
3 participants
@dkbast @Hixie @stuartmorgan