Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] Added onPushRoute; intercepts route pushes from the application host #3524

Closed

Conversation

sarbagyastha
Copy link
Contributor

@sarbagyastha sarbagyastha commented Mar 23, 2023

Adds onPushRoute to the GoRouter.

GoRouter(
  ...
  onPushRoute: (RouteInformation routeInformation) {
    final location = routeInformation.location;

    if(location == '/prevent') return PushRouteDecision.prevent; // intercepts the route completely
    if(location == '/delegate') return PushRouteDecision.delegate; // delegates the route to other binding observers to handle
    return PushRouteDecision.navigate; // default; the router handles the route
  }
)

Fixes flutter/flutter#103659
Fixes flutter/flutter#121870

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@chunhtai
Copy link
Contributor

This API currently can't differentiate between deeplink or browser backward and forward button. There are some efforts to send host information along with RouteInformation in case of deeplinks.
flutter/flutter#100624

I intend to close this one since this may be superseded once we start to handle host information.

@chunhtai chunhtai closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants