[webview_flutter_android] Adds a workaround fix for autofill #3588
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bparrishMines
changed the title
| flutterView.setImportantForAutofill(IMPORTANT_FOR_AUTOFILL_YES); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Alternative considered:
According to autofill docs, a view can get around a parent view setting IMPORTANT_FOR_AUTOFILL_YES_EXCLUDE_DESCENDANTS, if you do
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
final AutofillManager manager = getContext().getSystemService(AutofillManager.class);
manager.requestAutofill(webView);
}However, this would require a call to requestAutofill every time a page finished loading. I tried to call it when the view was instantiated, but autofill still didn't work. It only seemed to work if you call it once a page is loaded. My instinct is that it would be best to change the value of the parent and allow WebView to handle the autofill importance.
| } | ||
|
|
||
| return null; | ||
| } |
There was a problem hiding this comment.
The parents structure of Hybrid Composition and TLHC are different, so this should handle both cases.
bparrishMines
added
autosubmit
…#3588) [webview_flutter_android] Adds a workaround fix for autofill
Temporary fix for flutter/flutter#92165 until flutter/engine#40771 makes it to the minimum version of this plugin.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.