-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player] fix: add missing isPlaybackLikelyToKeepUp check. #3826
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
274ca4e
[video_player] Fix: add missing isPlaybackLikelyToKeepUp check. When …
unknown-undefined dc0e4be
[video_player] Fixes missing `isPlaybackLikelyToKeepUp` check for iOS…
unknown-undefined 0273fbe
[video_player] Add testBufferingStateFromPlayer test case and update …
unknown-undefined 00b0671
[video_player] Fix: add missing isPlaybackLikelyToKeepUp check
unknown-undefined ef0e78e
[video_player] Bump video_player_avfoundation version to 2.4.7 and ad…
unknown-undefined 899f0f1
[video_player] Add doc for iOS `playbackBufferEmpty` KVO bug. Refer: …
unknown-undefined 39b3e5c
[video_player] Add documentation explaining the use of `isPlaybackLik…
unknown-undefined 45c4c65
[video_player] Remove unneeded KVO to `isPlaybackBufferFull` or `isPl…
unknown-undefined c0ab678
Merge NEXT into current version.
stuartmorgan 68bab23
Merge branch 'main' into main
stuartmorgan 6006c78
Fix CHANGELOG merge
stuartmorgan b3e538a
Re-bump version
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also explain in the comment why we need to check
isPlaybackLikelyToKeepUp
here? (rather than the existing code?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hellohuanlin Thanks for the suggestion. Already updated.