[google_sign_in] Bump http to version 1.0.0 #4099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change, since dart SDK needs to be bumped to 3.0.0
kevmoo
reviewed
May 28, 2023
| @@ -33,7 +33,7 @@ dev_dependencies: | |||
| sdk: flutter | |||
| flutter_test: | |||
| sdk: flutter | |||
| http: ^0.13.0 | |||
| http: ^1.0.0 | |||
There was a problem hiding this comment.
You'll likely want to use a rang here...to avoid breaks
That's not a breaking change; the resolver won't offer a version to someone whose SDK doesn't support it. (But as Kevin points out above, changing the SDK range isn't necessary since we should allow both 0.13 and 1.0) |
|
Closing as this is obsoleted by #4147, which updates all of our packages, but thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change, since dart SDK needs to be bumped to 3.0.0
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.