Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for utf8.encode() to return more precise Uint8List type #4342

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Prepare for utf8.encode() to return more precise Uint8List type #4342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1ca066
Prepare for utf8.decode() to return more precise Uint8List type
mkustermann Jun 29, 2023
e96c7ae
Add packages/rfw/CHANGELOG.md entry
mkustermann Jun 30, 2023
e1a80da
Increment minor version number
mkustermann Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...image_picker/image_picker_for_web/example/integration_test/image_picker_for_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import 'package:integration_test/integration_test.dart';

const String expectedStringContents = 'Hello, world!';
const String otherStringContents = 'Hello again, world!';
final Uint8List bytes = utf8.encode(expectedStringContents) as Uint8List;
final Uint8List otherBytes = utf8.encode(otherStringContents) as Uint8List;
final Uint8List bytes = const Utf8Encoder().convert(expectedStringContents);
final Uint8List otherBytes = const Utf8Encoder().convert(otherStringContents);
final Map<String, dynamic> options = <String, dynamic>{
'type': 'text/plain',
'lastModified': DateTime.utc(2017, 12, 13).millisecondsSinceEpoch,
Expand Down
3 changes: 2 additions & 1 deletion packages/rfw/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## NEXT
## 1.0.10

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.
* Changes package internals to avoid explicit `as Uint8List` downcast.

## 1.0.9

Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/lib/src/dart/binary.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ class _BlobEncoder {
}

void _writeString(String value) {
final Uint8List buffer = utf8.encode(value) as Uint8List;
final Uint8List buffer = const Utf8Encoder().convert(value);
ditman marked this conversation as resolved.
Show resolved Hide resolved
_writeInt64(buffer.length);
bytes.add(buffer);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: rfw
description: "Remote Flutter widgets: a library for rendering declarative widget description files at runtime."
repository: https://github.com/flutter/packages/tree/main/packages/rfw
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+rfw%22
version: 1.0.9
version: 1.0.10

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down