Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cross_file] Improved documentation about ignored parameters in IO module. #4416

Merged
merged 36 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
2711ea8
Improved documentation about ignored parameters in IO module.
andreacioni Jul 9, 2023
fff92c0
improved comments
andreacioni Jul 9, 2023
adbf84f
fix changelog
andreacioni Jul 11, 2023
bbcf8ec
removed references to a new version
andreacioni Jul 17, 2023
9f25c1f
bump version
andreacioni Jul 17, 2023
694e210
removed NEXT and set new version
andreacioni Jul 17, 2023
694d807
Merge branch 'main' into main
andreacioni Jul 17, 2023
c108cc8
Merge branch 'main' into main
andreacioni Jul 17, 2023
86b22b0
Merge branch 'main' into main
andreacioni Jul 17, 2023
6c7afa6
Merge branch 'main' into main
andreacioni Jul 20, 2023
e38f619
doc: Add sentence to say mime type is not intended for io implementation
ValentinVignal Jul 22, 2023
6abf97d
chore: Update version
ValentinVignal Jul 22, 2023
765987c
Merge remote-tracking branch 'upstream/main' into cross-file/document…
ValentinVignal Jul 31, 2023
bc2871b
Merge branch 'main' into cross-file/document-that-mime-type-is-not-fo…
ValentinVignal Jul 31, 2023
b709d73
Merge branch 'flutter:main' into main
andreacioni Jul 31, 2023
f139130
Merge branch 'flutter:main' into main
andreacioni Jul 31, 2023
53ff79d
Merge branch 'main' into cross-file/document-that-mime-type-is-not-fo…
andreacioni Jul 31, 2023
ac4ecca
Merge pull request #1 from ValentinVignal/cross-file/document-that-mi…
andreacioni Jul 31, 2023
b79f71a
fix wrong version
andreacioni Jul 31, 2023
67bd439
Merge branch 'main' into main
andreacioni Aug 1, 2023
227f8eb
Merge branch 'main' into main
andreacioni Aug 2, 2023
565ce62
Merge branch 'main' into main
andreacioni Aug 12, 2023
782b52e
Merge branch 'main' into main
andreacioni Aug 23, 2023
3c8b540
Merge branch 'main' into main
andreacioni Aug 24, 2023
da4eed8
Merge branch 'main' into main
andreacioni Aug 30, 2023
9883eb0
remediating reported issues
andreacioni Aug 30, 2023
6c01856
version NEXT
andreacioni Aug 30, 2023
c33dc0d
bump version in pubspec.yaml
andreacioni Aug 30, 2023
7f813fd
add empty line
andreacioni Aug 30, 2023
6ff1faa
do not use NEXT as per guidelines
andreacioni Aug 30, 2023
222ef43
Merge branch 'main' into main
andreacioni Aug 31, 2023
7ebfdbf
Merge branch 'main' into main
andreacioni Sep 18, 2023
66b66e5
resolving PR comments
andreacioni Sep 18, 2023
b5f02c9
Merge branch 'main' into main
andreacioni Sep 18, 2023
5655816
name and length documentation moved to base.dart
andreacioni Sep 21, 2023
85aa45c
Merge branch 'main' into main
andreacioni Sep 21, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cross_file/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.3+6

* Improves documentation about ignored parameters in IO implementation.

## 0.3.3+5

* Adds pub topics to package metadata.
Expand Down
2 changes: 2 additions & 0 deletions packages/cross_file/lib/src/types/base.dart
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ abstract class XFileBase {

/// The name of the file as it was selected by the user in their device.
///
/// For non-web implementation, this represents the last part of the filesystem path.
///
/// Use only for cosmetic reasons, do not try to use this as a path.
String get name {
throw UnimplementedError('.name has not been implemented.');
Expand Down
10 changes: 10 additions & 0 deletions packages/cross_file/lib/src/types/io.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ class XFile extends XFileBase {
/// [bytes] is ignored; the parameter exists only to match the web version of
/// the constructor. To construct a dart:io XFile from bytes, use
/// [XFile.fromData].
///
/// [name] is ignored; the parameter exists only to match the web version of
/// the constructor.
///
/// [length] is ignored; the parameter exists only to match the web version of
/// the constructor.
///
// ignore: use_super_parameters
XFile(
String path, {
Expand All @@ -32,6 +39,9 @@ class XFile extends XFileBase {
super(path);

/// Construct an CrossFile from its data
///
/// [name] is ignored; the parameter exists only to match the web version of
/// the constructor.
XFile.fromData(
Uint8List bytes, {
String? mimeType,
Expand Down
2 changes: 1 addition & 1 deletion packages/cross_file/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: cross_file
description: An abstraction to allow working with files across multiple platforms.
repository: https://github.com/flutter/packages/tree/main/packages/cross_file
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+cross_file%22
version: 0.3.3+5
version: 0.3.3+6

environment:
sdk: ">=2.19.0 <4.0.0"
Expand Down