Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video_player] Add optional web options [Platform interface] #4433

Conversation

defuncart
Copy link
Contributor

@defuncart defuncart commented Jul 11, 2023

Platform Interface PR for Video Player Web Options (#3259).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@defuncart
Copy link
Contributor Author

@ditman Platform Interface PR for Video Player Web Options (#3259).

@tarrinneal
Copy link
Contributor

Do you intend to add tests to this pr? I don't believe the original pr included tests either. I didn't see an exemption, but I may have missed it.

@ditman
Copy link
Member

ditman commented Jul 11, 2023

@defuncart Tests can be easily added here:

Even if it's to expect an unimplemented error when calling the (unimplemented in this package) method, or the default values of the new types, no need to exempt this package from tests.

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-platform-interface branch from 1abf93d to 492c172 Compare July 13, 2023 12:20
@defuncart
Copy link
Contributor Author

@tarrinneal @ditman Added tests 🧪

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-platform-interface branch 2 times, most recently from fcc2bb8 to b11793f Compare July 13, 2023 12:23
@@ -1,6 +1,7 @@
## NEXT
Copy link
Member

@ditman ditman Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be published to be used by others, so I'd suggest:

Suggested change
## NEXT
## 6.2.0

(It will also require a change to the version field of the pubspec.yaml of the package.)

((Addressing the versioning of the package should fix the current repo_checks problem.))

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-platform-interface branch 2 times, most recently from 13c4892 to 2e16d82 Compare July 14, 2023 06:42
@defuncart
Copy link
Contributor Author

I'm not sure why the ci keeps failing

6.1.0 -> 6.2.0
When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.

As suggested, I tried

## NEXT
## 6.2.0

but the pipeline also failed. Any ideas? @ditman @tarrinneal

@ditman
Copy link
Member

ditman commented Jul 14, 2023

When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.

@defuncart, I think the confusing bit here is that ## NEXT is not something that gets automatically populated by our tooling when this gets published or anything, it's just a mark for our tools that means: "I'm adding a change to this repo that doesn't need to be published immediately, and can be deferred to the NEXT time somebody releases something, but that it's interesting for end users to know about." :)

The solution to the error is to completely remove ## NEXT and replace it by the version value being set in the pubspec.yaml (in this case ## NEXT -> ## 6.2.0).

I think that should make CI happy!

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman
Copy link
Member

ditman commented Jul 14, 2023

(We need a second review for this PR to land, I think. /cc @tarrinneal for whenever you have a few mins!)

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comment nits and I can approve

@defuncart defuncart force-pushed the feature/video-player/add-optional-web-options-platform-interface branch from ac62e34 to 4b74b47 Compare July 15, 2023 08:02
@defuncart
Copy link
Contributor Author

Thanks @ditman. Updated spelling @tarrinneal.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot merged commit c4a57a0 into flutter:main Jul 17, 2023
74 checks passed
@defuncart defuncart deleted the feature/video-player/add-optional-web-options-platform-interface branch July 18, 2023 09:33
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 18, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 jkbturek@gmail.com [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 stuartmorgan@google.com [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 defuncart@gmail.com [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478)
2023-07-17 yan.outside@gmail.com [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 43054281+camsim99@users.noreply.github.com [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 stuartmorgan@google.com Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 stuartmorgan@google.com [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 stuartmorgan@google.com [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
flutter/packages@6889cca...3e8b813

2023-07-18 jkbturek@gmail.com [video_player] Fix iOS crash with multiple players (flutter/packages#4202)
2023-07-17 stuartmorgan@google.com [pigeon] Enable Android emulator tests in CI (flutter/packages#4484)
2023-07-17 defuncart@gmail.com [video_player] Add optional web options [Platform interface] (flutter/packages#4433)
2023-07-17 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes for flutter#3258 (flutter/packages#4478)
2023-07-17 yan.outside@gmail.com [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826)
2023-07-17 43054281+camsim99@users.noreply.github.com [camerax] Add flash configuration for image capture (flutter/packages#3800)
2023-07-17 stuartmorgan@google.com Remove `equatable` and `xml` allowances (flutter/packages#4489)
2023-07-17 stuartmorgan@google.com [ci] Switch Linux platform tests to LUCI (flutter/packages#4479)
2023-07-17 stuartmorgan@google.com [ci] Adjust bot configurations (flutter/packages#4485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: video_player
Projects
None yet
3 participants