Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] tree fix format 2023 05 12 #4450

Closed
wants to merge 4 commits into from

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 12, 2023

  • Fix formatting as required by analyze repo tooling

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@reidbaker reidbaker changed the title tree fix format 2023 05 12 [camera] tree fix format 2023 05 12 Jul 12, 2023
@reidbaker
Copy link
Contributor Author

I dont think formatting changes need a changelog.

@reidbaker reidbaker added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 13, 2023
@stuartmorgan
Copy link
Contributor

This is failing the format check though.

Where was the failure this was intended to fix?

@reidbaker
Copy link
Contributor Author

This is failing the format check though.

Where was the failure this was intended to fix?

Something in our tree is changing. My first edit was to move a * char one space then the next failure was to move it back. Closing pr but also I dont know what was modified to make this flag then flag the improvement.

@reidbaker reidbaker closed this Jul 13, 2023
@reidbaker reidbaker deleted the tree-fix-format-2023-05-12 branch July 17, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes
Projects
None yet
2 participants