Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_wkwebview] add functions to display a system popup using Javascript in iOS #4538

Closed
wants to merge 2 commits into from

Conversation

jsharp83
Copy link
Contributor

@jsharp83 jsharp83 commented Jul 21, 2023

Description

Reference

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jsharp83 jsharp83 requested a review from cyanglaz as a code owner July 21, 2023 02:14
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor

Thanks for the contribution!

  • I'm wondering whether to expose this part as a System Popup or deliver the message to the Flutter.

The latter; it looks like we'd never documented that as the desired implementation in flutter/flutter#30358, so I've added a comment to that effect.

You appear to have simply copy-pasted code from that file into our implementation, which does not satisfy the terms of that code's license. We cannot accept code that you have not actually authored; please refer to item 5 of the CLA you signed.

Closing, as this is not code that we can accept. Please feel free to open a new PR if you decide to implement the approach described in flutter/flutter#30358 (comment) with code that is your own original work.

@niumj
Copy link

niumj commented Aug 18, 2023

@jsharp83
a2288e0

Thank you for your contents.But when I use it, system popup is working, the below error is also happened.
[[FWFUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:] was called more than once']
After that the app is exited.
How can I do or any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants