Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform] Example app for platform #4834

Merged
merged 43 commits into from
Oct 9, 2023
Merged

[platform] Example app for platform #4834

merged 43 commits into from
Oct 9, 2023

Conversation

chrisdlangham
Copy link
Contributor

@chrisdlangham chrisdlangham commented Sep 2, 2023 •
edited by stuartmorgan
Loading

This creates an example app for the platform package.

Fixes flutter/flutter#133471

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

chrisdlangham and others added 20 commits August 18, 2023 17:07
@chrisdlangham
converting url_launcher from objc to swift
1d5609f
@chrisdlangham
converting tests to swift
d5727dd
@chrisdlangham
converting tests to swift
c4e55fb
@chrisdlangham
fixing issue where pigeon and method channels were not setup right
050d6b3
@chrisdlangham
formatting
5278199
@chrisdlangham
reverting unintentional local changes
55a345b
@chrisdlangham
fixing issues with Ui tests
8356d7a
@chrisdlangham
formating
120b2d4
@chrisdlangham
Merge branch 'main' into coverting-objc-to-swift
1316f3c
@chrisdlangham
updating version and change log
7bd3553
@chrisdlangham
converting tests to swift
2741de4
@chrisdlangham
converting unit tests to swift
495de26
@chrisdlangham
Merge branch 'main' into converting-url-launcher-ios-tests-to-swift
c898698
@chrisdlangham
updating change log
6a6c8d5
@chrisdlangham
resolving merge conflicts
254b9af
@chrisdlangham
formatting
869f18f
@chrisdlangham
making test class final and private
1120baa
@chrisdlangham
adding example app for platform
1429244
@chrisdlangham
formatting and addressing linting errors
a4a6683
@chrisdlangham
updating version and change log
30a95d5
stuartmorgan
stuartmorgan requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

In addition to the comments below, please see the stdout of the CI failures listed here for other changes that will need to be made to bring the example into alignment with repository conventions and requirements.

packages/platform/linux/flutter/generated_plugins.cmake Outdated Show resolved Hide resolved
packages/platform/CHANGELOG.md Outdated Show resolved Hide resolved
packages/platform/example/pubspec.yaml Outdated Show resolved Hide resolved
packages/platform/example/pubspec.yaml Outdated Show resolved Hide resolved
packages/platform/example/pubspec.yaml Outdated Show resolved Hide resolved
packages/platform/example/pubspec.yaml Outdated Show resolved Hide resolved
packages/platform/example/android/app/build.gradle Outdated Show resolved Hide resolved
packages/platform/example/lib/main.dart Outdated Show resolved Hide resolved
packages/platform/example/lib/main.dart Show resolved Hide resolved
packages/platform/example/web/index.html Outdated Show resolved Hide resolved
@chrisdlangham
Copy link
Contributor Author

I belive this is ready for review.

@chrisdlangham
Revert "Merge branch 'coverting-objc-to-swift' into platform-example-…
1fb2d10 
…app"

This reverts commit 3a1190e, reversing
changes made to d320c35.
stuartmorgan
stuartmorgan requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to copy packages/platform/dart_test.yaml into the new example directory to resolve the web CI failures.

Other than than, I just have some small notes about cleaning up boilerplate. This looks great, thanks!

packages/platform/CHANGELOG.md Outdated Show resolved Hide resolved
packages/platform/example/android/app/build.gradle Outdated Show resolved Hide resolved
packages/platform/example/android/app/build.gradle Outdated Show resolved Hide resolved
packages/platform/example/android/app/build.gradle Outdated Show resolved Hide resolved
packages/platform/example/android/app/src/main/res/drawable-v21/launch_background.xml Outdated Show resolved Hide resolved
packages/platform/example/lib/main.dart Outdated Show resolved Hide resolved
packages/platform/example/lib/main.dart Outdated Show resolved Hide resolved
packages/platform/example/lib/main.dart Outdated Show resolved Hide resolved
packages/platform/example/macos/RunnerTests/RunnerTests.swift Outdated Show resolved Hide resolved
packages/platform/example/test/widget_test.dart Outdated Show resolved Hide resolved
@stuartmorgan
Copy link
Contributor

@tarrinneal Could you do the secondary review here? It's mostly boilerplate, only the Dart code and the metadata changes (pubspec, changelog) really need a second look.

stuartmorgan
stuartmorgan approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2023
@auto-submit auto-submit bot merged commit 0651975 into flutter:main Oct 9, 2023
70 checks passed
@chrisdlangham chrisdlangham deleted the platform-example-app branch October 9, 2023 15:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
0651975 [platform] Example app for platform (flutter/packages#4834)
e2194a4
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll
Roll Packages from 7de08ec to 4b483f2 (8 revisions) (#136258)
665c876 
flutter/packages@7de08ec...4b483f2

2023-10-10 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or macOS 13 (flutter/packages#5089)
2023-10-10 ychris@google.com [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085)
2023-10-09 stuartmorgan@google.com [process] Import the `process` package (flutter/packages#5095)
2023-10-09 hrkadam.92@gmail.com [go_router] Fixes missing state.extra in onException() (flutter/packages#5077)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093)
2023-10-09 chrislangham@rightnow.org [platform] Example app for platform (flutter/packages#4834)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from 7de08ec to 4b483f2 (8 revisions) (flutter#136258)
410e9d7 
flutter/packages@7de08ec...4b483f2

2023-10-10 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or macOS 13 (flutter/packages#5089)
2023-10-10 ychris@google.com [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085)
2023-10-09 stuartmorgan@google.com [process] Import the `process` package (flutter/packages#5095)
2023-10-09 hrkadam.92@gmail.com [go_router] Fixes missing state.extra in onException() (flutter/packages#5077)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094)
2023-10-09 engine-flutter-autoroll@skia.org Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093)
2023-10-09 chrislangham@rightnow.org [platform] Example app for platform (flutter/packages#4834)
2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@chrisdlangham @HugoOlthof
[platform] Example app for platform (flutter#4834)
eb8a0af 
This creates an example app for the platform package.

Fixes flutter/flutter#133471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android platform-ios platform-linux platform-macos platform-windows
Projects
None yet
Milestone
No milestone
3 participants
@chrisdlangham @stuartmorgan @tarrinneal