Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker] Add missing entitlements to macOS example #4931

Merged

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Sep 15, 2023

When endorsing macOS and adding the example app, I forgot to add the required entitlement, so the example didn't work.

The actual fix is the entitlements file; the Runner.xc* changes are auto-generated by running flutter build macos; usually we do that before landing examples but clearly I didn't remember to actually run the example when endorsing in this case...

Fixes flutter/flutter#134817

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

When endorsing macOS and adding the example app, I forgot to add the
required entitlement, so the example didn't work.

Fixes flutter/flutter#134817
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor Author

This currently can't be tested due to flutter/flutter#70234

Once that's implemented and we can do the UI testing backfill for this plugin, this will automatically be covered.

@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Sep 15, 2023
@stuartmorgan
Copy link
Contributor Author

No changelog: This only affects running locally, and is doing what the README already says to do.

@stuartmorgan
Copy link
Contributor Author

test-exempt: will be automatically covered once necessary test infrastructure lands

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TAMNTM

@stuartmorgan
Copy link
Contributor Author

Re-running repo_checks doesn't seem to be picking up the override at the moment for some reason. I'm going to force-land, but I'll look into that later today or next week.

@stuartmorgan stuartmorgan merged commit ba12bc5 into flutter:main Sep 15, 2023
70 of 71 checks passed
@stuartmorgan stuartmorgan deleted the image-picker-app-facing-macos-example branch September 15, 2023 17:04
@reidbaker reidbaker mentioned this pull request Sep 15, 2023
11 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 18, 2023
flutter/packages@bc8c2f2...d4e2454

2023-09-18 me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924)
2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940)
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938)
2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891)
2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934)
2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
flutter/packages@bc8c2f2...d4e2454

2023-09-18 me@nils.re [camera_android] Removes usage of `_ambiguate` method in example (flutter/packages#4924)
2023-09-17 engine-flutter-autoroll@skia.org Roll Flutter from e5e36ad to 1b18b13 (8 revisions) (flutter/packages#4940)
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter from 72b69f9 to e5e36ad (12 revisions) (flutter/packages#4938)
2023-09-15 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.5.0 to 1.7.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#4891)
2023-09-15 engine-flutter-autoroll@skia.org Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter/packages#4934)
2023-09-15 stuartmorgan@google.com [image_picker] Add missing entitlements to macOS example (flutter/packages#4931)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
When endorsing macOS and adding the example app, I forgot to add the
required entitlement, so the example didn't work.

The actual fix is the entitlements file; the Runner.xc* changes are
auto-generated by running `flutter build macos`; usually we do that
before landing examples but clearly I didn't remember to actually run
the example when endorsing in this case...

Fixes flutter/flutter#134817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: image_picker platform-macos
Projects
None yet
2 participants