Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview_flutter]Adds support to intercept JavaScript alert/confirm/prompt dialog. #5026

Closed
wants to merge 6 commits into from
Closed

[webview_flutter]Adds support to intercept JavaScript alert/confirm/prompt dialog. #5026

wants to merge 6 commits into from

Conversation

gtbluesky
Copy link

@gtbluesky gtbluesky commented Sep 28, 2023 •
edited

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gtbluesky and others added 2 commits September 29, 2023 01:23
@gtbluesky
Merge branch 'main' into javascript_dialog
1431b3c
@gtbluesky
Merge branch 'main' into javascript_dialog
4e63d02 
* main:
  [video_player] Endorse macOS (#5021)
  Manual roll Flutter from f92884c7b846 to ff4a0f676f41 (107 revisions) (#5011)
  [camera] Fix Android autofocus state reading (#5025)
@gtbluesky
Copy link
Author

Hi @bparrishMines ,could you please check my first PR for this project, thx!

@gtbluesky
Merge branch 'main' into javascript_dialog
7af36cf 
* main:
  Roll Flutter from d3df8f6bbf74 to d42313c04ba4 (4 revisions) (#5044)
  [webview_flutter] Adds app facing implementation to override console log (#4705)
  Roll Flutter from 57b5c3cda000 to d3df8f6bbf74 (24 revisions) (#5043)
  [webview_flutter] Add a method for getting the user agent (#4472)
  [webview_flutter_android] Fix race condition in flaky test (#5037)
  [ci] Wait for LUCI test checkin in `release` (#4911)
  [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (#4927)
  [ci] Disable maps tests in Android emulator (#5003)
  [camera] Dispose resources correctly on setDescription (#4003)
  [webview_flutter_android] Adds Android implementation to override console log (#4702)
  [camera] Remove `@throw` from iOS implementation (#5034)
  Roll Flutter from ff4a0f676f41 to 57b5c3cda000 (47 revisions) (#5036)
@gtbluesky
Merge branch 'main' into javascript_dialog
37a3d8a 
* main:
  [flutter_markdown] Code decoration (#5060)
  [webview_flutter] Exposes missing `JavaScriptLogLevel` from platform interface (#5061)
  Roll Flutter from d42313c04ba4 to 57ed72417780 (11 revisions) (#5059)
@gtbluesky
Merge branch 'main' into javascript_dialog
5aab113 
* main:
  [webview_flutter] [webview_flutter_wkwebview]Fix race condition in flaky test (#5068)
  Roll Flutter from 57ed72417780 to 512299113fa0 (21 revisions) (#5067)
  [webview_flutter_wkwebview] Fixes bug where `WebkitWebViewController.getUserAgent` was incorrectly returning an empty String  (#5062)
@bparrishMines
Copy link
Contributor

@gtbluesky Correct me if I'm wrong, but this is adding the same feature as #4704. That PR is already in the process of review, so I'm going to close this one in favor of the other one.

@gtbluesky
Copy link
Author

@bparrishMines you are right, but my PR implementation is more standardized and according to your review requirements.

@bparrishMines
Copy link
Contributor

@gtbluesky I'm not sure what you mean by that, but the other PR was following https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
p: webview_flutter platform-android platform-ios
Projects
None yet
Milestone
No milestone
2 participants
@gtbluesky @bparrishMines