[in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@bparrishMines All checks are passing now, Could you please review it ? |
2 tasks
bparrishMines
approved these changes
Oct 11, 2023
packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
tarrinneal
approved these changes
Oct 11, 2023
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
…urchase to completePurchase. (flutter/packages#5081)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
…urchase to completePurchase. (flutter/packages#5081)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2023
…urchase to completePurchase. (flutter/packages#5081)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2023
flutter/packages@4b483f2...93c3f69 2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121) 2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416) 2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081) 2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106) 2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096) 2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903) 2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986) 2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038) 2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f to 83134ac (25 revisions) (flutter/packages#5104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…letePurchase. (flutter#5081) ## What type of PR is this? (check all applicable) ## Description finishPurchase was mentioned in the doc, but does not exist in the package, instead completePurchase is used now, so updating the comment link. ## Fix Updated finishPurchase to completePurchase. ## Related Tickets & Documents - Closes [#135769](flutter/flutter#135759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
finishPurchase was mentioned in the doc, but does not exist in the package, instead completePurchase is used now, so updating the comment link.
Fix
Updated finishPurchase to completePurchase.
Related Tickets & Documents
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).