Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

Merged
merged 1 commit into from Nov 29, 2023
Merged

Fix Google Maps rendering issues in TLHC mode when using LATEST renderer #5408

merged 1 commit into from Nov 29, 2023

Conversation

johnmccutchan
Copy link
Contributor

The Google Maps LATEST renderer always uses a TextureView. We can use a signal from this TextureView to perform view invalidation that fixes the rendering glitches (missing updates) in TLHC mode.

NOTE: We have an internal bug 311013682 requesting an official way of achieving this functionality but if the bug is ever acted on it will take many months/years before we can rely on this functionality.

In the meantime, chain the internal SurfaceTextureListener with our own and piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView.

Fixes flutter/flutter#103686

Tested on an emulator and a physical device (Pixel 6 Pro).

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan
stuartmorgan requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update https://pub.dev/packages/google_maps_flutter_android#texture-layer-hybrid-composition with new guidance. Although if possible, we should also switch the default if this resolves the issue (and leave the switch only as an escape hatch if there are surprise issues). I think this would address all cases:

  • LATEST would always get this codepath (and work)
  • LEGACY would presumably either get this codepath (and work) or hit the SurfaceView codepath in Maps and then automatically fall out of TLHC anyway due to the engine fallback logic (so work).

Does that sound right?

...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java Show resolved Hide resolved
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java Show resolved Hide resolved
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java Show resolved Hide resolved
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java Outdated Show resolved Hide resolved
@johnmccutchan
Copy link
Contributor Author

We should update https://pub.dev/packages/google_maps_flutter_android#texture-layer-hybrid-composition with new guidance. Although if possible, we should also switch the default if this resolves the issue (and leave the switch only as an escape hatch if there are surprise issues). I think this would address all cases:

  • LATEST would always get this codepath (and work)
  • LEGACY would presumably either get this codepath (and work) or hit the SurfaceView codepath in Maps and then automatically fall out of TLHC anyway due to the engine fallback logic (so work).

Does that sound right?

I've updated the docs, PTAL.

@johnmccutchan johnmccutchan force-pushed the fix_invalidation_logic branch 2 times, most recently from 2fef5b7 to e876142 Compare November 16, 2023 17:20
stuartmorgan
stuartmorgan reviewed Nov 19, 2023
View reviewed changes
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart Outdated Show resolved Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md Outdated Show resolved Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md Outdated Show resolved Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md Outdated Show resolved Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/README.md Outdated Show resolved Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/README.md Outdated Show resolved Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart Show resolved Hide resolved
@johnmccutchan johnmccutchan force-pushed the fix_invalidation_logic branch 3 times, most recently from aff0ac9 to 5598ba1 Compare November 21, 2023 03:41
This was referenced Nov 27, 2023
Closed
Closed
@johnmccutchan johnmccutchan force-pushed the fix_invalidation_logic branch 6 times, most recently from 77ccc8f to df36585 Compare November 28, 2023 19:31
@johnmccutchan
Fix Google Maps rendering issues in TLHC mode when using LATEST renderer
d7bf4aa 
The Google Maps LATEST renderer always uses a TextureView. We can use a signal
from this TextureView to perform view invalidation that fixes the rendering
glitches (missing updates) in TLHC mode.

NOTE: We have an internal bug 311013682 requesting an official way of achieving
this functionality but if the bug is ever acted on it will take many months/years
before we can rely on this functionality.

In the meantime, chain the internal SurfaceTextureListener with our own and
piggyback on the OnSurfaceTextureUpdated callback to invalidate the MapView.

Fixes flutter/flutter#103686

Tested on an emulator and a physical device (Pixel 6 Pro).
stuartmorgan
stuartmorgan approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md

* Fixes missing updates in TLHC mode.
* Switched default display mode to TLHC mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Switches

(Per our style guide for changelogs.)

@johnmccutchan johnmccutchan merged commit e393d45 into flutter:main Nov 29, 2023
80 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
e393d45 Fix Google Maps rendering issues in TLHC mode when using LATE…
e9dca6e 
…ST renderer (flutter/packages#5408)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
Roll Packages from e4aaba8 to bc72d15 (4 revisions) (#139307)
995a020 
flutter/packages@e4aaba8...bc72d15

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@johnmccutchan @HugoOlthof
Fix Google Maps rendering issues in TLHC mode when using LATEST rende…
b6a183b 
…rer (flutter#5408)

The Google Maps LATEST renderer always uses a TextureView. We can use a
signal from this TextureView to perform view invalidation that fixes the
rendering glitches (missing updates) in TLHC mode.

NOTE: We have an internal bug 311013682 requesting an official way of
achieving this functionality but if the bug is ever acted on it will
take many months/years before we can rely on this functionality.

In the meantime, chain the internal SurfaceTextureListener with our own
and piggyback on the OnSurfaceTextureUpdated callback to invalidate the
MapView.

Fixes flutter/flutter#103686

Tested on an emulator and a physical device (Pixel 6 Pro).
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@engine-flutter-autoroll @caseycrogers
Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter#139307)
6ff9f23 
flutter/packages@e4aaba8...bc72d15

2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add platform interface" (flutter/packages#5524)
2023-11-30 louisehsu@google.com [pointer_interceptor] Add platform interface (flutter/packages#5499)
2023-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) (flutter/packages#5519)
2023-11-29 john@johnmccutchan.com Fix Google Maps rendering issues in TLHC mode when using LATEST renderer (flutter/packages#5408)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@note11g note11g mentioned this pull request Jan 4, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@reidbaker reidbaker reidbaker approved these changes

Assignees
No one assigned
Labels
p: google_maps_flutter platform-android
Projects
None yet
Milestone
No milestone
3 participants
@johnmccutchan @stuartmorgan @reidbaker