Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multicast_dns] Adjust README #5529

Merged
merged 4 commits into from
Dec 9, 2023
Merged

[multicast_dns] Adjust README #5529

merged 4 commits into from
Dec 9, 2023

Conversation

stuartmorgan
Copy link
Contributor

  • Improves link targets to be more directly useful.
  • Removes the unnecessary code sections showing an import, since the install tab already demonstrates that.
  • Removes the no-longer-needed exemption from the excerpt requirement.

Part of flutter/flutter#102679

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[multicast_dns] Adjust README
9cd2f89 
- Improves link targets to be more directly useful.
- Removes the unnecessary code sections showing an import, since the
  install tab already demonstrates that.
- Removes the no-longer-needed exemption from the excerpt requirement.

Part of flutter/flutter#102679
tarrinneal
tarrinneal approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've really managed to fail a lot of tests for a readme update!

@stuartmorgan
Copy link
Contributor Author

You've really managed to fail a lot of tests for a readme update!

I started looking at a system that would let us be smarter about what tests we run when we touch a script/config/ file, but it's non-trivial and I haven't had time to really dig in. So for now we're stuck with this situation where it runs everything :|

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 6, 2023

auto label is removed for flutter/packages/5529, due to - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2023
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Dec 6, 2023

auto label is removed for flutter/packages/5529, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2023
@auto-submit auto-submit bot merged commit cb6dbcd into flutter:main Dec 9, 2023
80 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
cb6dbcd [multicast_dns] Adjust README (flutter/packages#5529)
2599c5b
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (#139911)
935d12c 
flutter/packages@6cd0657...cb6dbcd

2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@stuartmorgan @HugoOlthof
[multicast_dns] Adjust README (flutter#5529)
1173fed 
- Improves link targets to be more directly useful.
- Removes the unnecessary code sections showing an import, since the install tab already demonstrates that.
- Removes the no-longer-needed exemption from the excerpt requirement.

Part of flutter/flutter#102679
Michal-MK pushed a commit to Michal-MK/flutter that referenced this pull request Jan 8, 2024
@engine-flutter-autoroll @Michal-MK
Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter#139911)
8231c25 
flutter/packages@6cd0657...cb6dbcd

2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Markzipan pushed a commit to Markzipan/flutter that referenced this pull request Jan 9, 2024
@engine-flutter-autoroll @Markzipan
Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter#139911)
b92dac0 
flutter/packages@6cd0657...cb6dbcd

2023-12-09 stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529)
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623)
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612)
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629)
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614)
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619)
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625)
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580)
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered  by a user action (flutter/packages#5143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@dnfield dnfield Awaiting requested review from dnfield

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: multicast_dns
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @tarrinneal