-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Pin master for CI tests #554
Conversation
Updates to match the recent change in flutter/plugins, to use a pinned version of master instead of the latest version. This uses the last version of master that passed post-submit tests due to a current out-of-band failure in golden tests. This affects both the Cirrus tests and the Windows LUCI tests. Part of flutter/flutter#93811
Once this lands (so the target file is in place) I'll get the autoroller set up. |
Actually, since we have a fix for the breakage we can do this in two parts. I'll send a separate PR to create the file unused. |
Creates a target file for a Flutter master pin autoroller. This is currently unused, but creating it allows setting up the autoroller. Prepares for flutter#554 Part of flutter/flutter#93811
Creates a target file for a Flutter master pin autoroller. This is currently unused, but creating it allows setting up the autoroller. Prepares for #554 Part of flutter/flutter#93811
This PR will now just enable using the version file. We can wait until the autoroller is running to land this. |
The autoroller is working! Its first roll has landed :) So we're ready to move forward with this. |
# Master uses a pinned, auto-rolled version to prevent out-of-band CI | ||
# failures due to changes in Flutter. | ||
# TODO(stuartmorgan): Investigate an autoroller for stable as well. | ||
- TARGET_TREEISH=$CHANNEL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What's a "treeish"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an official git term: https://git-scm.com/docs/gitglossary#:~:text=tree%2Dish%20(also%20treeish),the%20revision's%20top%20directory.
In this case, this variable contains either a hash or a branch name, which are very different things in many ways but are both treeish values, which means they can be checked out.
Updates to match the recent change in flutter/plugins, to use a pinned
version of master updated by an autoroller instead of the latest version.
This affects both the Cirrus tests and the Windows LUCI tests.
Part of flutter/flutter#93811
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).