Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Pin master for CI tests #554

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Jan 25, 2022

Updates to match the recent change in flutter/plugins, to use a pinned
version of master updated by an autoroller instead of the latest version.

This affects both the Cirrus tests and the Windows LUCI tests.

Part of flutter/flutter#93811

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Updates to match the recent change in flutter/plugins, to use a pinned
version of master instead of the latest version. This uses the last
version of master that passed post-submit tests due to a current
out-of-band failure in golden tests.

This affects both the Cirrus tests and the Windows LUCI tests.

Part of flutter/flutter#93811
@stuartmorgan
Copy link
Contributor Author

Once this lands (so the target file is in place) I'll get the autoroller set up.

@stuartmorgan
Copy link
Contributor Author

Actually, since we have a fix for the breakage we can do this in two parts. I'll send a separate PR to create the file unused.

stuartmorgan added a commit to stuartmorgan/packages that referenced this pull request Jan 25, 2022
Creates a target file for a Flutter master pin autoroller. This is
currently unused, but creating it allows setting up the autoroller.

Prepares for flutter#554

Part of flutter/flutter#93811
stuartmorgan added a commit that referenced this pull request Jan 25, 2022
Creates a target file for a Flutter master pin autoroller. This is
currently unused, but creating it allows setting up the autoroller.

Prepares for #554

Part of flutter/flutter#93811
@stuartmorgan
Copy link
Contributor Author

This PR will now just enable using the version file. We can wait until the autoroller is running to land this.

@stuartmorgan
Copy link
Contributor Author

The autoroller is working! Its first roll has landed :) So we're ready to move forward with this.

# Master uses a pinned, auto-rolled version to prevent out-of-band CI
# failures due to changes in Flutter.
# TODO(stuartmorgan): Investigate an autoroller for stable as well.
- TARGET_TREEISH=$CHANNEL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: What's a "treeish"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an official git term: https://git-scm.com/docs/gitglossary#:~:text=tree%2Dish%20(also%20treeish),the%20revision's%20top%20directory.

In this case, this variable contains either a hash or a branch name, which are very different things in many ways but are both treeish values, which means they can be checked out.

@stuartmorgan stuartmorgan merged commit ddc0059 into flutter:main Jan 27, 2022
@stuartmorgan stuartmorgan deleted the pin-master branch January 27, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants