Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 #6591

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Apr 22, 2024

Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like #6522 that are failing due to a what a clear warning* describes as a potential issue:

Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".

Other dependabot upgrades that I believe are blocked by this change:
#6585
#6534
#6530
#6528
#6526

*Added in flutter/flutter#143341

Pre-launch Checklist

@camsim99 camsim99 changed the title Bump legacy all_packages project AGP version from 4.1.0 to 7.0.0 Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 Apr 22, 2024
@camsim99 camsim99 marked this pull request as ready for review April 22, 2024 18:29
@camsim99 camsim99 requested review from stuartmorgan and a team April 22, 2024 18:29
@reidbaker reidbaker self-requested a review April 22, 2024 19:05
@reidbaker
Copy link
Contributor

I think this work is also related to flutter/flutter#146660 because AGP 8.3 being used in a package prevents adoption in the legacy project.

@camsim99
Copy link
Contributor Author

I believe this also addresses what flutter/flutter#137181 is about and should address concerns about modifying the legacy all_packages app noted in #5032 (comment).

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2024
@auto-submit auto-submit bot merged commit 080fd74 into flutter:main Apr 23, 2024
78 checks passed
@stuartmorgan
Copy link
Contributor

This was prompted by dependabot AGP version upgrades like #6522 that are failing due to a what a clear warning* describes as a potential issue:
[...]
*Added in flutter/flutter#143341

That's not on stable yet. Do we really want the legacy test no longer catching problems that will break people on stable?

I would have expected this PR to wait until the next stable release.

@stuartmorgan
Copy link
Contributor

Also, I would recommend that we set the minimum Flutter SDK version for all *_android packages to the version with that error message before we lose this test coverage. Otherwise when we start landing dependabot updates that break people (intending to rely on the new warning), people on 3.19 and 3.16 will also be broken, but without the useful messages.

@reidbaker
Copy link
Contributor

If @gmackall's work to warn on old versions is not in stable I think we need to revert this pr.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2024
@camsim99 camsim99 added the revert Label used to revert changes in a closed and merged pull request. label Apr 24, 2024
Copy link
Contributor

auto-submit bot commented Apr 24, 2024

A reason for requesting a revert of flutter/packages/6591 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Apr 24, 2024
@camsim99
Copy link
Contributor Author

Reason for revert: Warning about unsupported Android dependency versions (added in flutter/flutter#143341) not in stable.

@camsim99 camsim99 added the revert Label used to revert changes in a closed and merged pull request. label Apr 24, 2024
auto-submit bot pushed a commit that referenced this pull request Apr 24, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Apr 24, 2024
auto-submit bot added a commit that referenced this pull request Apr 24, 2024
…e version to 7.0.2 (#6591)" (#6605)

Reverts: #6591
Initiated by: camsim99
Reason for reverting: Warning about unsupported Android dependency versions (added in flutter/flutter#143341) not in stable.
Original PR Author: camsim99

Reviewed By: {reidbaker, gmackall}

This change reverts the following previous change:
Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like #6522 that are failing due to a what a clear warning* describes as a potential issue:

```
Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".
```

Other dependabot upgrades that I believe are blocked by this change:
#6585
#6534
#6530
#6528
#6526

*Added in flutter/flutter#143341
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 25, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 25, 2024
flutter/packages@cf6d280...fde908d

2024-04-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/packages#6609)
2024-04-24 32538273+ValentinVignal@users.noreply.github.com [go_router] Add `GoRouterState state` parameter to `GoRouterData.onExit` (flutter/packages#6495)
2024-04-24 15619084+vashworth@users.noreply.github.com Add CI steps to test iOS and macOS plugins with both CocoaPods and Swift Package Manager (flutter/packages#6557)
2024-04-24 engine-flutter-autoroll@skia.org Roll Flutter from 77043ba to dba4f77 (30 revisions) (flutter/packages#6607)
2024-04-24 stuartmorgan@google.com [camera] Finish converting iOS to Pigeon (flutter/packages#6601)
2024-04-24 47866232+chunhtai@users.noreply.github.com [go_router] Fixes an issue where route future does not complete when � (flutter/packages#6596)
2024-04-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (#6591)" (flutter/packages#6605)
2024-04-23 reidbaker@google.com [in_app_purchase_android] Readme update for Alternative billing (flutter/packages#6578)
2024-04-23 43054281+camsim99@users.noreply.github.com Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6591)
2024-04-23 engine-flutter-autoroll@skia.org Roll Flutter from 140edb9 to 77043ba (21 revisions) (flutter/packages#6599)
2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.1 to 3.25.2 (flutter/packages#6597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan
Copy link
Contributor

I've done all the repo updates for 3.22, so it should be possible to make an updated version of this PR that makes affected plugins require 3.22 now.

@camsim99
Copy link
Contributor Author

@stuartmorgan that would be changing the Flutter version for all packages that run on Android right (excluding platform interfaces I assume)?

@stuartmorgan
Copy link
Contributor

You only need to change the min SDK actual Android implementation packages. It's fine for people to use newer versions of the app-facing packages with older versions of the implementation package (up until the point where someone updates the min version of the Android implementation package in the app-facing package, at which point CI will force them to update the app-facing package's minimum accordingly).

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
… to 7.0.2 (flutter#6591)

Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like flutter#6522 that are failing due to a what a clear warning* describes as a potential issue:

```
Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".
```

Other dependabot upgrades that I believe are blocked by this change:
flutter#6585
flutter#6534
flutter#6530
flutter#6528
flutter#6526

*Added in flutter/flutter#143341
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…e version to 7.0.2 (flutter#6591)" (flutter#6605)

Reverts: flutter#6591
Initiated by: camsim99
Reason for reverting: Warning about unsupported Android dependency versions (added in flutter/flutter#143341) not in stable.
Original PR Author: camsim99

Reviewed By: {reidbaker, gmackall}

This change reverts the following previous change:
Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like flutter#6522 that are failing due to a what a clear warning* describes as a potential issue:

```
Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".
```

Other dependabot upgrades that I believe are blocked by this change:
flutter#6585
flutter#6534
flutter#6530
flutter#6528
flutter#6526

*Added in flutter/flutter#143341
auto-submit bot pushed a commit that referenced this pull request May 29, 2024
…le version to 7.0.2 (#6742)

Re-lands #6591.

The only difference between that PR and this one is that this PR bumps the required Flutter version of Android facing packages to the latest Flutter stable version (3.22) that weren't doing so already. That is because the stable version includes the warning about using older versions of Android dependencies.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
… to 7.0.2 (flutter#6591)

Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like flutter#6522 that are failing due to a what a clear warning* describes as a potential issue:

```
Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".
```

Other dependabot upgrades that I believe are blocked by this change:
flutter#6585
flutter#6534
flutter#6530
flutter#6528
flutter#6526

*Added in flutter/flutter#143341
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…e version to 7.0.2 (flutter#6591)" (flutter#6605)

Reverts: flutter#6591
Initiated by: camsim99
Reason for reverting: Warning about unsupported Android dependency versions (added in flutter/flutter#143341) not in stable.
Original PR Author: camsim99

Reviewed By: {reidbaker, gmackall}

This change reverts the following previous change:
Upgrades legacy all_packages project AGP version to 7.0.0 and Gradle version to 7.0.2 as Flutter will begin enforcing supported versions for these Android dependencies.

This was prompted by dependabot AGP version upgrades like flutter#6522 that are failing due to a what a clear warning* describes as a potential issue:

```
Warning: Flutter support for your project's Gradle version (6.7.1) will soon be dropped. Please upgrade your Gradle version to a version of at least 7.0.2 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's gradle version is typically defined in the gradle wrapper file. By default, this can be found at /b/s/w/ir/x/w/packages/legacy/all_packages/android/gradle/wrapper/gradle-wrapper.properties. 
For more information, see https://docs.gradle.org/current/userguide/gradle_wrapper.html.

Warning: Flutter support for your project's Android Gradle Plugin version (4.1.0) will soon be dropped. Please upgrade your Android Gradle Plugin version to a version of at least 7.0.0 soon.
Alternatively, use the flag "--android-skip-build-dependency-validation" to bypass this check.

Potential fix: Your project's AGP version is typically defined the plugins block of the `settings.gradle` file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle), by a plugin with the id of com.android.application. 
If you don't see a plugins block, your project was likely created with an older template version. In this case it is most likely defined in the top-level build.gradle file (/b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle) by the following line in the dependencies block of the buildscript: "classpath 'com.android.tools.build:gradle:<version>'".
```

Other dependabot upgrades that I believe are blocked by this change:
flutter#6585
flutter#6534
flutter#6530
flutter#6528
flutter#6526

*Added in flutter/flutter#143341
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…le version to 7.0.2 (flutter#6742)

Re-lands flutter#6591.

The only difference between that PR and this one is that this PR bumps the required Flutter version of Android facing packages to the latest Flutter stable version (3.22) that weren't doing so already. That is because the stable version includes the warning about using older versions of Android dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
4 participants