-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Clean up maxDuration
code
#7039
Merged
auto-submit
merged 11 commits into
flutter:main
from
stuartmorgan:camera-max-duration-unwind
Jul 10, 2024
Merged
[camera] Clean up maxDuration
code
#7039
auto-submit
merged 11 commits into
flutter:main
from
stuartmorgan:camera-max-duration-unwind
Jul 10, 2024
+103
−666
Commits on Jul 1, 2024
-
[camera] Clean up partial maxVideoDuration code
`maxVideoDuration` was added to the platform interface a long time ago in preparation for adding that feature, but the other parts were never landed. The previous state was: - It has never been implemented for iOS or Android - It has never been settable from the app-facing package, so is always null unless someone uses the platform interface directly, which we don't consider a supported use case. - It cannot be implemented in the CameraX Android implementation. - It was implemented for Windows and web because when those platforms were added much later, nobody realized that the parameter was unused. There is no compelling need for this feature, as clients of the plugin can simply set their own timer to stop recording. Given that, rather than leave the confusing partial state, this marks the option as deprecated at the platform interface layer and warns implementers that it can be ignored. It also removes the implementations from Windows and web in order to reduce implementation complexity, since that code was not reachable from the app-facing API. This does not consider the Windows and web changes to be breaking, even though they arguably could be, because we do not expect clients to be calling platform interface methods directly.
Configuration menu - View commit details
-
Copy full SHA for c7e4c51 - Browse repository at this point
Copy the full SHA c7e4c51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b4562b - Browse repository at this point
Copy the full SHA 2b4562bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f96c85 - Browse repository at this point
Copy the full SHA 0f96c85View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b7df77 - Browse repository at this point
Copy the full SHA 5b7df77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2b169 - Browse repository at this point
Copy the full SHA 2a2b169View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7621a68 - Browse repository at this point
Copy the full SHA 7621a68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8988fde - Browse repository at this point
Copy the full SHA 8988fdeView commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 737f326 - Browse repository at this point
Copy the full SHA 737f326View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f144214 - Browse repository at this point
Copy the full SHA f144214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83c10bf - Browse repository at this point
Copy the full SHA 83c10bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9638b62 - Browse repository at this point
Copy the full SHA 9638b62View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.