Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Clean up maxDuration code #7039

Merged
merged 11 commits into from
Jul 10, 2024

Commits on Jul 1, 2024

  1. [camera] Clean up partial maxVideoDuration code

    `maxVideoDuration` was added to the platform interface a long time ago
    in preparation for adding that feature, but the other parts were never
    landed. The previous state was:
    - It has never been implemented for iOS or Android
    - It has never been settable from the app-facing package, so is always
      null unless someone uses the platform interface directly, which we
      don't consider a supported use case.
    - It cannot be implemented in the CameraX Android implementation.
    - It was implemented for Windows and web because when those platforms
      were added much later, nobody realized that the parameter was unused.
    
    There is no compelling need for this feature, as clients of the plugin
    can simply set their own timer to stop recording. Given that, rather
    than leave the confusing partial state, this marks the option as
    deprecated at the platform interface layer and warns implementers that
    it can be ignored. It also removes the implementations from Windows and
    web in order to reduce implementation complexity, since that code was
    not reachable from the app-facing API.
    
    This does not consider the Windows and web changes to be breaking, even
    though they arguably could be, because we do not expect clients to be
    calling platform interface methods directly.
    stuartmorgan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c7e4c51 View commit details
    Browse the repository at this point in the history
  2. Minor fixup

    stuartmorgan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2b4562b View commit details
    Browse the repository at this point in the history
  3. Test fixes

    stuartmorgan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0f96c85 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    5b7df77 View commit details
    Browse the repository at this point in the history
  2. Windows fixes

    stuartmorgan committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2a2b169 View commit details
    Browse the repository at this point in the history
  3. Fix iOS version

    stuartmorgan committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7621a68 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8988fde View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    737f326 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    f144214 View commit details
    Browse the repository at this point in the history
  2. Missed Windows cleanup

    stuartmorgan committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    83c10bf View commit details
    Browse the repository at this point in the history
  3. Merge fix

    stuartmorgan committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9638b62 View commit details
    Browse the repository at this point in the history