Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[animations] Refresh README #97

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

shihaohong
Copy link

@shihaohong shihaohong commented Feb 18, 2020

Continues #95 with some minor tweaks.

Click link to see what the README looks like on GitHub.

cc/ @jojomcbobo @goderbauer

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump the version in the pubspec and add an entry to the changelog so we can publish this?


Currently, the following animated effects are available in this library:
This package contains a set of transition patterns that help users understand and navigate an app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This packages" .. is odd here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reworded this in a later change

@shihaohong shihaohong mentioned this pull request Feb 18, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong shihaohong merged commit 5f901fb into flutter:master Feb 18, 2020
@shihaohong shihaohong changed the title Refresh README [animations] Refresh README Feb 18, 2020
@shihaohong shihaohong deleted the readme-improvements branch February 21, 2020 18:48
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants