Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
[camera] Move ignores for body_might_complete_normally_catch_error (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
srawlins committed Sep 13, 2022
1 parent 822f668 commit 17aed71
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 18 deletions.
11 changes: 5 additions & 6 deletions packages/camera/camera_android/lib/src/android_camera.dart
Expand Up @@ -138,12 +138,11 @@ class AndroidCamera extends CameraPlatform {
'cameraId': cameraId,
'imageFormatGroup': imageFormatGroup.name(),
},
)
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError(
).catchError(
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
(Object error, StackTrace stackTrace) {
if (error is! PlatformException) {
throw error;
Expand Down
Expand Up @@ -138,12 +138,11 @@ class AVFoundationCamera extends CameraPlatform {
'cameraId': cameraId,
'imageFormatGroup': imageFormatGroup.name(),
},
)
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError(
).catchError(
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
(Object error, StackTrace stackTrace) {
if (error is! PlatformException) {
throw error;
Expand Down
Expand Up @@ -130,12 +130,11 @@ class MethodChannelCamera extends CameraPlatform {
'cameraId': cameraId,
'imageFormatGroup': imageFormatGroup.name(),
},
)
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError(
).catchError(
// TODO(srawlins): This should return a value of the future's type. This
// will fail upcoming analysis checks with
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
(Object error, StackTrace stackTrace) {
if (error is! PlatformException) {
throw error;
Expand Down

0 comments on commit 17aed71

Please sign in to comment.