Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
Cleanup obsolete --compact-async compiler option (#118894)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexmarkov committed Jan 20, 2023
1 parent ec6ff90 commit 492d572
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions packages/flutter_tools/lib/src/compile.dart
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ import 'convert.dart';

/// Opt-in changes to the dart compilers.
const List<String> kDartCompilerExperiments = <String>[
// improve AOT code size.
'--compact-async',
];

/// The target model describes the set of core libraries that are available within
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ void main() {
'--no-print-incremental-dependencies',
'-Ddart.vm.profile=true',
'-Ddart.vm.product=false',
'--compact-async',
'--no-link-platform',
'--aot',
'--tfa',
Expand Down Expand Up @@ -249,7 +248,6 @@ void main() {
'--no-print-incremental-dependencies',
'-Ddart.vm.profile=false',
'-Ddart.vm.product=true',
'--compact-async',
'--no-link-platform',
'--aot',
'--tfa',
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/general.shard/compile_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,11 @@ void main() {
testWithoutContext('buildModeOptions removes matching profile define in profile mode', () {
expect(buildModeOptions(BuildMode.profile, <String>['dart.vm.profile=true']), <String>[
'-Ddart.vm.product=false',
'--compact-async'
]);
});

testWithoutContext('buildModeOptions removes both matching profile and release define in profile mode', () {
expect(buildModeOptions(BuildMode.profile, <String>['dart.vm.profile=false', 'dart.vm.product=true']), <String>[
'--compact-async'
]);
});
}

0 comments on commit 492d572

Please sign in to comment.