This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update dart doc for forceSafariVC for the usage of universal links on iOS #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2019 17:36
cbracken
reviewed
Jan 10, 2019
| @@ -20,9 +20,10 @@ const MethodChannel _channel = MethodChannel('plugins.flutter.io/url_launcher'); | |||
| /// [forceSafariVC] is only used in iOS. If unset, the launcher opens web URLs | |||
| /// in the safari VC, anything else is opened using the default handler on the | |||
There was a problem hiding this comment.
While you're here, consider replacing safari VC with Safari view controller.
cbracken
reviewed
Jan 10, 2019
| @@ -20,9 +20,10 @@ const MethodChannel _channel = MethodChannel('plugins.flutter.io/url_launcher'); | |||
| /// [forceSafariVC] is only used in iOS. If unset, the launcher opens web URLs | |||
There was a problem hiding this comment.
To make it a tiny bit more obvious, maybe: By default (when unset), the launcher opens HTTP/HTTPS URLs...
cbracken
reviewed
Jan 10, 2019
| /// If false, the URL is opened in the default browser of the phone. Note that | ||
| /// to work with universal links on iOS, this must be set to false to let | ||
| /// the platform's system handle the URL. Set this to false if you want to | ||
| /// use the cookies/context of the main browser of the app(such as SSO flows). |
There was a problem hiding this comment.
Add a space between app and (such as SSO flows).
cbracken
approved these changes
Jan 10, 2019
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
… iOS (flutter#1058) Update dart document to explain forceSafariVC flag regarding universal link on IOS There are numbers of users having problem on launch universal links on iOS. It is most likely due to the unawareness of forceSafariVC is true by default and safariVC will not handle universal links.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…links on iOS (flutter#1058)" This reverts commit dcc6f24.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numbers of users having problem on launch universal links on iOS.
It is most likely due to the unawareness of forceSafariVC is true by default and safariVC will not handle universal links.
Adding document to explain this particular usage.