This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
cleanup #1102
Merged
cleanup #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jan 23, 2019
|
|
amirh
reviewed
Jan 23, 2019
| @@ -1,3 +1,7 @@ | |||
| ## 4.1.0+1 | |||
|
|
|||
| * Clean up. | |||
There was a problem hiding this comment.
Not sure I'll know what to expect when reading this in a change log, maybe worth being a little more explicit here.
And somewhat related - I think that it's generally helpful when the PR description / commit message say what was done, in this case I think "Bump url_lanuncher's version" would have been a good description (specifically I pulled up this PR as it triggered a build failure, with a more detailed description I could probably know its not this PR fault just from the message)
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 5c54382.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.