This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Pause/resume video recording for Android & iOS #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
huulbaek
changed the title
bparrishMines
approved these changes
Aug 6, 2019
mklim
reviewed
Aug 7, 2019
|
|
||
| try { | ||
| mediaRecorder.pause(); | ||
| result.success(null); |
There was a problem hiding this comment.
nit: This should be outside of the try block here and below, just in the weird offhand chance calling this throws an IllegalStateException. If it did result.error would also throw in the catch block.
13 tasks
bparrishMines
changed the title
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
* Pause/resume video recording for Android * Specify type * Add pausing and resuming to example app * iOS side of pausing/resuming * More documentation * Version bump * Add video pausing and resuming * get pausing and recording to work for no audio * It works * Formatting * Add test for pausing and resuming * Call success outside try catch block * formatting * Disable audio in test and call result on iOS
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Upgraded Crashlytics to v2 of Flutter Plugins.
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
* Pause/resume video recording for Android * Specify type * Add pausing and resuming to example app * iOS side of pausing/resuming * More documentation * Version bump * Add video pausing and resuming * get pausing and recording to work for no audio * It works * Formatting * Add test for pausing and resuming * Call success outside try catch block * formatting * Disable audio in test and call result on iOS
11 tasks
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this for a small project that needed the functionality. I'm not well versed in the plugin structure and JAVA, so if it's completely off, let me know. Also, I would implement it for iOS too, but it doesn't seem that straightforward.