Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] fix "Cancel button not visible in gallery, if camera was accessed first" #1372

Merged
merged 3 commits into from
Apr 23, 2019
Merged

[image_picker] fix "Cancel button not visible in gallery, if camera was accessed first" #1372

merged 3 commits into from
Apr 23, 2019

Conversation

ivk1800
Copy link
Contributor

@ivk1800 ivk1800 commented Mar 21, 2019

@ivk1800 ivk1800 requested a review from cyanglaz as a code owner March 21, 2019 17:06
@ivk1800 ivk1800 changed the title fix "Cancel button not visible in gallery, if camera was accessed first" [image_picker] fix "Cancel button not visible in gallery, if camera was accessed first" Mar 21, 2019
@amirh amirh added this to Awaiting initial triage in [experimental] Plugins PR tracking Mar 29, 2019
cyanglaz
cyanglaz reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified your code and it does seem to fix the issue. However, I couldn't figure out the root cause of the original issue. If there is a root cause we might want to figure it out and fix the root cause.

@cyanglaz cyanglaz self-assigned this Apr 23, 2019
@cyanglaz cyanglaz merged commit d6bbf43 into flutter:master Apr 23, 2019
[experimental] Plugins PR tracking automation moved this from Awaiting initial triage to Done Apr 23, 2019
This was referenced Apr 25, 2019
Closed
Closed
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@bparrishMines
[firebase_dynamic_links] support v2 embedding (flutter#1372)
8bf9b22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz left review comments

Assignees

@cyanglaz cyanglaz

Labels
bugfix cla: yes
Projects
No open projects
[experimental] Plugins PR tracking
  
Done
Milestone
No milestone
4 participants
@ivk1800 @cyanglaz @googlebot @bparrishMines