This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity]Added integration test. #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Apr 5, 2019
| _connectivity = Connectivity(); | ||
| }); | ||
|
|
||
| test('test _checkConnectivity', () async { |
There was a problem hiding this comment.
I would remove test and underscore
| expect(result, isNotNull); | ||
| }); | ||
|
|
||
| test('test connectivity result', () async { |
There was a problem hiding this comment.
We could probably combine this test with the one above.
| enableFlutterDriverExtension(handler: (_) => completer.future); | ||
| tearDownAll(() => completer.complete(null)); | ||
|
|
||
| group('Connectivity test driver', () { |
There was a problem hiding this comment.
Elsewhere in the plugins repo we use the stringified class name '$Connectivity' to identify group so you may want to be consistent with that, though it's not required. I wouldn't say "test driver" though.
packages/connectivity/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 0.4.2+2 | |||
|
|
|||
| * Add test driver. | |||
There was a problem hiding this comment.
I would say "Added integration test." Although we're using Flutter driver to launch the test, we don't use the FlutterDriver API to do anything, so it may be confusing otherwise.
|
lgtm modulo the nits above |
cyanglaz
changed the title
added 3 commits
April 5, 2019 16:24
|
looks ready to merge |
collinjackson
added
the
submit queue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test driver to the plugin.