Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_admob] Fix firebase_admob crash when used with android alarm manager #1515

Merged
merged 11 commits into from Jul 16, 2019

Conversation

SachinGanesh
Copy link
Contributor

Description

Fixes crash when used with flutter_background_fetch

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SachinGanesh
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@collinjackson collinjackson self-requested a review July 15, 2019 18:50
@collinjackson collinjackson added the submit queue The Flutter team is in the process of landing this PR. label Jul 15, 2019
@collinjackson collinjackson merged commit 4c94c73 into flutter:master Jul 16, 2019
mithun-mondal pushed a commit to bKash-developer/plugins that referenced this pull request Aug 6, 2019
…m manager (flutter#1515)

* -- Fix crash when used with android alarm manager
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…m manager (flutter#1515)

* -- Fix crash when used with android alarm manager
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla: yes flutterfire submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
5 participants