Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

firebase_admob exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 #1631

Closed
wants to merge 1 commit into from

Conversation

skyberk
Copy link

@skyberk skyberk commented May 23, 2019

Description

AdView be placed with frame location under ios 11. But translatesAutoresizingMaskIntoConstraints has NO flag.

Related Issues

flutter/flutter#27457

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@skyberk
Copy link
Author

skyberk commented May 23, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@skyberk
Copy link
Author

skyberk commented May 23, 2019

Sure .

Copy link

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plateaukao
Copy link

May I know when this PR will be merged? It's quite bothering that I have to apply this change locally in order to have a workable plugin for my app.

@westy92
Copy link

westy92 commented Jul 12, 2019

Same! Hoping for a review and release soon. 🤞

@westy92
Copy link

westy92 commented Aug 19, 2019

Maybe this will get some attention if you add [firebase_admob] to the start of the title?

@westy92
Copy link

westy92 commented Aug 19, 2019

Tagging @collinjackson to make sure this doesn't fall through the cracks. Thanks!

@skyberk skyberk changed the title exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 firebase_admob exclude translatesAutoresizingMaskIntoConstraints = NO under ios 11 Aug 19, 2019
@skyberk
Copy link
Author

skyberk commented Aug 19, 2019

Thanks for suggestions i changed to start of title @westy92 also i am tagging to @collinjackso n.

@collinjackson
Copy link
Contributor

I've migrated this PR to the new repo: firebase/flutterfire#45

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
5 participants