Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_ml_vision] Prepare example app to include Live Camera Preview demo and Material Barcode Scanner demo #1713

Merged
merged 4 commits into from Jun 13, 2019

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jun 7, 2019

Description

This PR reorganizes the example app to use a list that allows access to multiple MLVision examples. Including a Live Camera Preview and a Material Design Barcode Scanner.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.


class _MyHomePage extends StatefulWidget {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This widget was moved to picture_scanner.dart and renamed to PictureScanner.

@bparrishMines bparrishMines changed the title [WIP] Mlkit demo Mlkit demo Jun 11, 2019
@bparrishMines bparrishMines changed the title Mlkit demo [firebase_ml_vision] Prepare example app to include Live Camera Preview demo and Material Barcode Scanner demo Jun 11, 2019
@bparrishMines bparrishMines merged commit e9766e6 into flutter:master Jun 13, 2019
@bparrishMines bparrishMines deleted the mlkit_demo branch June 13, 2019 23:29
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants