Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fixed code example error & README links #1751

Merged
merged 9 commits into from Jul 9, 2019
Merged

[in_app_purchase] Fixed code example error & README links #1751

merged 9 commits into from Jul 9, 2019

Conversation

creativecreatorormaybenot
Copy link
Contributor 

const Set<String> _kIds = <String>['product1', 'product2'].toSet();

That is not a valid assignment. Hence, I fixed it and on the way I also updated all the links in the README that either did not work at all or did not work from the pub page.

@creativecreatorormaybenot
Copy link
Contributor Author

@cyanglaz @mklim I thought this was a quick one. Is there something wrong with it?

cyanglaz
cyanglaz approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @mklim for the link

packages/in_app_purchase/README.md Show resolved Hide resolved
packages/in_app_purchase/README.md Outdated Show resolved Hide resolved
@cyanglaz cyanglaz added submit queue The Flutter team is in the process of landing this PR. documentation labels Jul 8, 2019
mklim
mklim reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

One nit: this also needs pubspec.yaml to be updated.

packages/in_app_purchase/README.md Show resolved Hide resolved
@creativecreatorormaybenot
Copy link
Contributor Author

@mklim Done.

mklim
mklim approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@mklim mklim self-assigned this Jul 8, 2019
@mklim mklim merged commit 9bf69f3 into flutter:master Jul 9, 2019
@creativecreatorormaybenot creativecreatorormaybenot deleted the iap-readme-fixes branch July 9, 2019 18:45
mithun-mondal pushed a commit to bKash-developer/plugins that referenced this pull request Aug 6, 2019
@creativecreatorormaybenot @mithun-mondal
[in_app_purchase] Fixed code example error & README links (flutter#1751)
a1d848c 
```dart
const Set<String> _kIds = <String>['product1', 'product2'].toSet();
```

That is not a valid assignment. Hence, I fixed it and on the way I also updated all the links in the README that either did not work at all or did not work from the [pub page](https://pub.dev/packages/in_app_purchase#-readme-tab-).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@mklim mklim mklim approved these changes

Assignees

@mklim mklim

Labels
cla: yes documentation submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Milestone
No milestone
4 participants
@creativecreatorormaybenot @cyanglaz @mklim @googlebot