This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[all_plugins] Compile all plugins together #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
commented
Jul 9, 2019
| package="io.plugins.all_plugins" | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
|
|
||
| <uses-sdk tools:overrideLibrary="io.flutter.plugins.camera"/> |
There was a problem hiding this comment.
Required because camera plugin is 21+
bparrishMines
commented
Jul 9, 2019
| REPO_DIR="$(dirname "$SCRIPT_DIR")" | ||
|
|
||
| source "$SCRIPT_DIR/common.sh" | ||
| check_changed_packages > /dev/null | ||
|
|
||
| cd $REPO_DIR/examples/all_plugins | ||
| flutter clean > /dev/null | ||
| (cd "$REPO_DIR" && pub global run flutter_plugin_tools gen-pubspec --exclude firebase_core,firebase_ml_vision) |
There was a problem hiding this comment.
Exclude firebase_core because all the other firebase plugins depend on it. This caused a problem when compiling.
Exclude firebase_ml_vision because it requires iOS 9.0+ which caused a problem when compiling with google_maps_flutter. I didn't want to change either plugin in this PR.
There was a problem hiding this comment.
sgtm. note that we'll be moving these plugins out of this repo soon.
bparrishMines
changed the title
| REPO_DIR="$(dirname "$SCRIPT_DIR")" | ||
|
|
||
| source "$SCRIPT_DIR/common.sh" | ||
| check_changed_packages > /dev/null | ||
|
|
||
| cd $REPO_DIR/examples/all_plugins | ||
| flutter clean > /dev/null | ||
| (cd "$REPO_DIR" && pub global run flutter_plugin_tools gen-pubspec --exclude firebase_core,firebase_ml_vision) |
There was a problem hiding this comment.
sgtm. note that we'll be moving these plugins out of this repo soon.
mithun-mondal
pushed a commit
to bKash-developer/plugins
that referenced
this pull request
Aug 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pubspec generating tool to
build_all_plugins_app.shscript. This will add all the plugins in the repo to the all_plugins app and test compilation.