Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_crashlytics] Update README with advice on testing installation #1815

Merged
merged 4 commits into from Jul 8, 2019

Conversation

nerder
Copy link
Contributor

@nerder nerder commented Jul 8, 2019

Description

This section will give feedback on when the installation goes fine, plus informing user that firebase takes a while to display the collected crashes into the Firebase Console, since the time is quite long (almost a day) i think it's better to give a feedback here.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This section will give feedback on when the installation goes fine, plus informing user that `firebase` takes a while to display the collected crashes into the Firebase Console, since the time is quite long (almost a day) i think it's better to give a feedback here.
@collinjackson collinjackson changed the title [firebase_crashlytics] Add the result section for successfully installations [firebase_crashlytics] Update README with advice on testing installation Jul 8, 2019
@collinjackson collinjackson merged commit 9591d3c into flutter:master Jul 8, 2019
mithun-mondal pushed a commit to bKash-developer/plugins that referenced this pull request Aug 6, 2019
…ion (flutter#1815)

* Add the result section for successfully installations

This section will give feedback on when the installation goes fine, plus informing user that `firebase` takes a while to display the collected crashes into the Firebase Console, since the time is quite long (almost a day) i think it's better to give a feedback here.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…ion (flutter#1815)

* Add the result section for successfully installations

This section will give feedback on when the installation goes fine, plus informing user that `firebase` takes a while to display the collected crashes into the Firebase Console, since the time is quite long (almost a day) i think it's better to give a feedback here.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants